support parsing unix abstract socket

[ktmlm]

tendermint core can accept unix abstract socket, but this crate can NOT parse it.

this pr fix this issue.

ref:

• man 7 unix on Linux
• https://golang-examples.tumblr.com/post/92025745979/pitfall-of-abstract-unix-domain-socket-address-in-go

[tony-iqlusion]

It might make sense to file this logic below with the rest of the code that handles the unix:// prefix.

However, if you want to keep it like this, I'd suggest using strip_prefix:

Suggested change

	if addr.starts_with("unix://@") {
	return Ok(Self::Unix {
	path: addr.trim_start_matches("unix://").to_owned(),
	});
	}
	if let Some(path) = addr.strip_prefix("unix://@") {
	return Ok(Self::Unix {
	path: path.to_owned(),
	});
	}

Edit: I now see this doesn't properly handle the @, so I guess that doesn't work.

[ktmlm]

yes, the '@' should be kept, your suggestions can not run.

'moving this code block to the rest of the code that handles the unix:// prefix', this is a good idea, but a unix://@... is very likely to be denied by the following Url::parse

[ktmlm]

the change I commit are the only one case that get tested in my practice

[codecov-commenter]

Codecov Report

Merging #1205 (3c03b9d) into main (00401ae) will increase coverage by 0.0%.
The diff coverage is 50.0%.

@@          Coverage Diff          @@
##            main   #1205   +/-   ##
=====================================
  Coverage   64.0%   64.0%           
=====================================
  Files        250     250           
  Lines      21554   21560    +6     
=====================================
+ Hits       13798   13805    +7     
+ Misses      7756    7755    -1     

Impacted Files	Coverage Δ
config/src/net.rs	90.1% <50.0%> (-2.1%)	⬇️
testgen/src/header.rs	82.9% <0.0%> (-0.6%)	⬇️
tendermint/src/node.rs	63.9% <0.0%> (+0.1%)	⬆️
light-client-verifier/src/types.rs	38.7% <0.0%> (+0.2%)	⬆️
testgen/src/vote.rs	84.8% <0.0%> (+0.8%)	⬆️
tendermint/src/block/commit_sig.rs	80.3% <0.0%> (+1.9%)	⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[thanethomson]

Seems reasonable to me. I'd be very interested to know who actually uses abstract Unix domain sockets with Tendermint.