Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix release script when a crate is not yet published at all on crates.io #1316

Merged
merged 2 commits into from
May 3, 2023
Merged

Fix release script when a crate is not yet published at all on crates.io #1316

merged 2 commits into from
May 3, 2023

Conversation

romac
Copy link
Member

@romac romac commented May 3, 2023 •
edited
Loading

Closes: #1315

  • Referenced an issue explaining the need for the change
  • Updated all relevant documentation in docs
  • Updated all code comments where relevant
  • Wrote tests
  • Added entry in .changelog/

@romac romac requested a review from thanethomson May 3, 2023 16:46
@romac
Copy link
Member Author

romac commented May 3, 2023

I also added a README for the light client CLI, otherwise we can't publish the crate.

thanethomson
thanethomson approved these changes May 3, 2023
View reviewed changes
Copy link
Contributor

@thanethomson thanethomson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! I remember running into this problem before and having to manually upload a crate the first time. Neat solution 🙂

@romac romac merged commit eb7e757 into main May 3, 2023
@romac romac deleted the romac/fix-release-script branch May 3, 2023 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thanethomson thanethomson thanethomson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Release script fails when crate is not yet published at all on crates.io
2 participants
@romac @thanethomson