Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to CometBFT 0.38.0 release #1365

Merged
merged 3 commits into from
Oct 2, 2023

Conversation

mzabaluev
Copy link
Contributor

@mzabaluev mzabaluev commented Oct 2, 2023

Since v0.38.0-rc3, there were quite a few fields added to the
RequestExtendVote message.
Represent them in the domain type for the request.

  • Referenced an issue explaining the need for the change
  • Updated all relevant documentation in docs
  • Updated all code comments where relevant
  • Wrote tests
  • Added entry in .changelog/

Since v0.38.0-rc3, there were quite a few fields added to the
RequestExtendVote message. Represent them in the domain type for
the request.
@mzabaluev mzabaluev changed the base branch from mikhail/reimplement-hyper-proxy to main October 2, 2023 13:59
@romac romac self-requested a review October 2, 2023 14:02
@mzabaluev mzabaluev marked this pull request as ready for review October 2, 2023 14:18
@codecov-commenter
Copy link

Codecov Report

Merging #1365 (5d5735f) into main (33b3c10) will decrease coverage by 0.1%.
The diff coverage is 0.0%.

❗ Current head 5d5735f differs from pull request most recent head 960b906. Consider uploading reports for the commit 960b906 to get more accurate results

@@           Coverage Diff           @@
##            main   #1365     +/-   ##
=======================================
- Coverage   61.2%   61.2%   -0.1%     
=======================================
  Files        274     274             
  Lines      26818   26844     +26     
=======================================
  Hits       16433   16433             
- Misses     10385   10411     +26     
Files Coverage Δ
tendermint/src/abci/request/extend_vote.rs 0.0% <0.0%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mzabaluev mzabaluev merged commit 7db0413 into main Oct 2, 2023
23 checks passed
@mzabaluev mzabaluev deleted the mikhail/update-to-cometbft-0.38-release branch October 2, 2023 14:34
@sergio-mena
Copy link

Thanks for this @mzabaluev , and sorry for the lack of coordination on this one. Next one will be better 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants