Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpc: Add FromStr, Serialize and Deserialize instances to CompatMode #1367

Merged
merged 4 commits into from
Mar 14, 2024

Conversation

romac
Copy link
Member

@romac romac commented Oct 4, 2023

Closes: #1374

  • Referenced an issue explaining the need for the change
  • Updated all relevant documentation in docs
  • Updated all code comments where relevant
  • Wrote tests
  • Added entry in .changelog/

@romac romac requested a review from mzabaluev October 4, 2023 16:06
@codecov-commenter
Copy link

Codecov Report

Merging #1367 (2b9c024) into main (bcc0b37) will increase coverage by 0.0%.
The diff coverage is 71.7%.

❗ Current head 2b9c024 differs from pull request most recent head eb7ff64. Consider uploading reports for the commit eb7ff64 to get more accurate results

@@          Coverage Diff          @@
##            main   #1367   +/-   ##
=====================================
  Coverage   61.2%   61.2%           
=====================================
  Files        274     274           
  Lines      26844   26890   +46     
=====================================
+ Hits       16433   16466   +33     
- Misses     10411   10424   +13     
Files Coverage Δ
rpc/src/error.rs 95.6% <100.0%> (+0.2%) ⬆️
rpc/src/client/compat.rs 79.3% <63.8%> (-10.9%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@xla xla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@romac
Copy link
Member Author

romac commented Nov 1, 2023

Looks like the test coverage job is failing because of changes in supported unstable flags on nightly:

error: failed to run `rustc` to learn about target-specific information
error: unknown unstable option: `instrument-coverage`

rpc/src/error.rs Show resolved Hide resolved
rpc/src/error.rs Show resolved Hide resolved
@romac romac merged commit 6e2baf2 into main Mar 14, 2024
25 checks passed
@romac romac deleted the compatmode-fromstr branch March 14, 2024 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rpc: Add FromStr, Serialize and Deserialize instances to CompatMode
4 participants