Set encoding explicitly in setup.py #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This wouldn't have worked on windows if we had non ASCII characters in the README or history, see https://www.python.org/dev/peps/pep-0597/#using-the-default-encoding-is-a-common-mistake
Codecov Report
@@ Coverage Diff @@
## master #145 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 7 7
Lines 179 179
Branches 26 26
=========================================
Hits 179 179 Continue to review full report at Codecov.
|
CorrosiveKid
approved these changes
Feb 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This wouldn't have worked on windows if we had non ASCII characters in the README or history, see
https://www.python.org/dev/peps/pep-0597/#using-the-default-encoding-is-a-common-mistake