Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vault snap fix #170

Merged
merged 11 commits into from
Jul 26, 2022
Merged

Vault snap fix #170

merged 11 commits into from
Jul 26, 2022

Conversation

johnalotoski
Copy link
Contributor

@johnalotoski johnalotoski commented Jul 20, 2022 •
edited
Loading

  • add an includeReplica option for snapshots
  • make overriding snapshotJobConfig defaults easier
  • refactor: the snap scripts to add includeReplica support and general script clean up
  • refactor: multiple snapshot modules into one hashi-snapshot module
  • disable vault snapshot on replicas temporarily while a bug exists in the latest Vault version

@johnalotoski johnalotoski force-pushed the vault-snap-fix branch 2 times, most recently from 496f7ae to 3be6acd Compare July 21, 2022 20:52
dermetfan
dermetfan approved these changes Jul 26, 2022
View reviewed changes
modules/hashi-snapshots.nix Outdated Show resolved Hide resolved
modules/hashi-snapshots.nix Outdated Show resolved Hide resolved
modules/hashi-snapshots.nix Outdated Show resolved Hide resolved
@johnalotoski johnalotoski merged commit fc281ec into master Jul 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manveru manveru manveru approved these changes

@dermetfan dermetfan dermetfan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@johnalotoski @manveru @dermetfan