Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added ability to operate based on title #49

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Added ability to operate based on title #49

wants to merge 3 commits into from
+53 −9

Conversation

pawalt
Copy link

@pawalt pawalt commented Oct 16, 2017

I noticed that each time I wanted to edit/trash/markdown/pin a task, I had to list and find the key. I made some changes so that you can do all those based on title.

samuelallan72
samuelallan72 suggested changes Oct 26, 2017
View reviewed changes
Copy link

@samuelallan72 samuelallan72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this idea! However, there is a lot of repetition in the code (from line 1409 down) - I'd prefer if this was refactored or restructured before merging so that it's a bit more maintainable.

@samuelallan72 samuelallan72 mentioned this pull request Jul 17, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samuelallan72 samuelallan72 samuelallan72 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pawalt @samuelallan72