Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define type Serializable #495

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

hugelgupf
Copy link
Collaborator

Toward lazy option parsing -- which I'm not 100% sure should be applied everywhere anymore, but at least should be applied to vendor options for ease of use of the library.

Bit of test coverage improvement here, too.

Signed-off-by: Chris Koch <chrisko@google.com>
Signed-off-by: Chris Koch <chrisko@google.com>
Signed-off-by: Chris Koch <chrisko@google.com>
@codecov
Copy link

codecov bot commented Mar 5, 2023

Codecov Report

Patch coverage: 87.30% and project coverage change: +0.01 🎉

Comparison is base (3e45eea) 72.88% compared to head (50801df) 72.90%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #495      +/-   ##
==========================================
+ Coverage   72.88%   72.90%   +0.01%     
==========================================
  Files          90       90              
  Lines        5728     5728              
==========================================
+ Hits         4175     4176       +1     
  Misses       1381     1381              
+ Partials      172      171       -1     
Impacted Files Coverage Δ
dhcpv6/duid.go 84.61% <ø> (ø)
dhcpv6/types.go 91.66% <ø> (ø)
dhcpv6/dhcpv6message.go 78.75% <76.92%> (-0.06%) ⬇️
dhcpv6/dhcpv6relay.go 85.09% <82.35%> (-0.33%) ⬇️
dhcpv6/options.go 92.48% <83.33%> (-0.89%) ⬇️
dhcpv6/dhcpv6.go 77.31% <100.00%> (+3.59%) ⬆️
dhcpv6/option_iaaddress.go 92.50% <100.00%> (-0.53%) ⬇️
dhcpv6/option_iapd.go 94.00% <100.00%> (-0.34%) ⬇️
dhcpv6/option_iaprefix.go 94.64% <100.00%> (-0.19%) ⬇️
dhcpv6/option_nontemporaryaddress.go 94.54% <100.00%> (-0.29%) ⬇️
... and 3 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: Chris Koch <chrisko@google.com>
Signed-off-by: Chris Koch <chrisko@google.com>
Moves towards avoiding allocating a new buf.NewBigEndianBuffer in every
single FromBytes / ToBytes function.

Signed-off-by: Chris Koch <chrisko@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants