Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added node v20 support #805

Merged
merged 21 commits into from
Jun 30, 2023
Merged

feat: added node v20 support #805

merged 21 commits into from
Jun 30, 2023

Conversation

kirrg001
Copy link
Contributor

@kirrg001 kirrg001 commented Jun 15, 2023

@kirrg001
Copy link
Contributor Author

kirrg001 commented Jun 16, 2023

Node v20 worker threads: somehow we get false for the main thread inside the test env. Investigating

Running a CJS dummy app -> isMainThread is true
Running a ESM dummy app -> isMainThread is false

https://nodejs.org/en/blog/announcements/v20-release-announce

Custom ES module lifecycle hooks supplied via loaders (--experimental-loader=./foo.mjs) now run in a dedicated thread, isolated from the main thread. This provides a separate scope for loaders and ensures no cross-contamination between loaders and application code.

@kirrg001 kirrg001 marked this pull request as ready for review June 30, 2023 07:34
@kirrg001 kirrg001 requested a review from a team as a code owner June 30, 2023 07:34
@kirrg001 kirrg001 merged commit 830259f into main Jun 30, 2023
1 of 2 checks passed
@kirrg001 kirrg001 deleted the feat/nodev20 branch June 30, 2023 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant