Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

root can purge enclave from shard config #238

Merged
merged 6 commits into from
Dec 23, 2023
Merged

root can purge enclave from shard config #238

merged 6 commits into from
Dec 23, 2023

Conversation

brenzi
Copy link
Contributor

@brenzi brenzi commented Dec 22, 2023 •
edited
Loading

closes #237

minimum viable solution: just let root clean up

plus some general cleanups

@brenzi brenzi changed the title Ab/purge enclave from shard config root can purge enclave from shard config Dec 22, 2023
@brenzi brenzi requested a review from clangenb December 22, 2023 15:56
clangenb
clangenb approved these changes Dec 22, 2023
View reviewed changes
Copy link
Contributor

@clangenb clangenb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor questions, looks good to me otherwise.

enclave-bridge/src/lib.rs Outdated Show resolved Hide resolved
enclave-bridge/src/lib.rs Show resolved Hide resolved
enclave-bridge/src/lib.rs Outdated Show resolved Hide resolved
@brenzi brenzi merged commit aa1cc76 into master Dec 23, 2023
11 checks passed
This was referenced Dec 23, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clangenb clangenb clangenb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

stale validateer stay in ShardStatus forever
2 participants
@brenzi @clangenb