Include sl_util.h to define MIN in mini_snprintf.h #308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mauriceyap
approved these changes
Sep 5, 2018
|
This header file is added to support Switchless Calls. And there is a MIN definition in the header file (common/inc/internal/sl_util.h) for switchless. How about including the header file to this header? |
Signed-off-by: Dionna Glaze <dionnaglaze@google.com>
deeglaze
force-pushed
the
expand_undefined_min_macro
branch
from
07fd35d
to
ebf2179
Compare
deeglaze
changed the title
|
Updated. |
llly
added a commit
to llly/linux-sgx
that referenced
this pull request
Sep 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The MIN macro is not defined in any of the included headers.
Since it's only used in one place, replace the use with the intended
expansion instead of defining MIN.
Signed-off-by: Dionna Glaze dionnaglaze@google.com