Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ESIMD][NFC] Rework L1/L2 cache hints passing across internal funcs(p… #12935

Merged

Conversation

v-klochkov
Copy link
Contributor

…art2)

gather_impl(), scatter_impl(), atomic_update_impl(), prefetch_impl() now accept a list of properties that may include L1/L2 cache-hints instead of L1/L2 template parameters.

As part of the clean-up this patch also:

  • removes __esimd_lsc_load_stateless declaration and lowering to GenX (it is replaced by __esimd_lsc_load_merge_stateless)
  • all uses of check_cache_hint() are replaced by check_cache_hints() accepting a list of properties
  • removed check_lsc_cache_hint()

…art2)

gather_impl(), scatter_impl(), atomic_update_impl(), prefetch_impl() now accept
a list of properties that may include L1/L2 cache-hints instead of L1/L2
template parameters.

Signed-off-by: Klochkov, Vyacheslav N <vyacheslav.n.klochkov@intel.com>
@v-klochkov v-klochkov marked this pull request as ready for review March 7, 2024 15:03
@v-klochkov v-klochkov requested a review from a team as a code owner March 7, 2024 15:03
Copy link
Contributor

@sarnex sarnex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup!

@v-klochkov
Copy link
Contributor Author

Windows CI task fail is unrelated to this PR.

@v-klochkov v-klochkov merged commit 96d744f into intel:sycl Mar 7, 2024
12 of 13 checks passed
@v-klochkov v-klochkov deleted the esimd_L1_L2_rework_L3_assert_part2 branch March 7, 2024 15:49
sarnex pushed a commit that referenced this pull request Mar 22, 2024
…13104)

Even though the fresh ESIMD headers do not use 'lsc_load_stateless()`
intrinsic, the static libraries compiled by an old compiler may still
have the calls of 'lsc_load_stateless' in them.

The patch #12935 caused regressions in
some MKL tests.
This patch here restores the lowering of lsc_load_stateless for
sycl-post-link backward compatibility.

Signed-off-by: Klochkov, Vyacheslav N <vyacheslav.n.klochkov@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants