Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Run E2E tests on PVC, with and without dev-igc #15308

Open
wants to merge 18 commits into
base: sycl
Choose a base branch
from

Conversation

uditagarwal97
Copy link
Contributor

No description provided.

@uditagarwal97 uditagarwal97 self-assigned this Sep 5, 2024
@uditagarwal97 uditagarwal97 marked this pull request as ready for review September 5, 2024 22:04
@uditagarwal97 uditagarwal97 requested a review from a team as a code owner September 5, 2024 22:04
@uditagarwal97
Copy link
Contributor Author

Need to update CI container first to test changes in this PR: #15324

@uditagarwal97 uditagarwal97 marked this pull request as draft September 12, 2024 22:28
@YuriPlyakhin
Copy link
Contributor

@uditagarwal97,
I noticed some Joint Matrix tests are skipped. I believe, it is because some tests are still using "matrix" feature and it is not passed to lit. Is it possible to pass this parameter to lit for now, until I clean this up in tests?

@uditagarwal97
Copy link
Contributor Author

@uditagarwal97, I noticed some Joint Matrix tests are skipped. I believe, it is because some tests are still using "matrix" feature and it is not passed to lit. Is it possible to pass this parameter to lit for now, until I clean this up in tests?

@YuriPlyakhin I already pass --param gpu-intel-pvc=True LIT option for now (https://github.com/intel/llvm/pull/15308/files#diff-bcddf1bc08cdd8b2a69b2c952d9ccd3b3d5c1e5302b39f5780d3d3568cd36a6a). Do we need to pass some other LIT option as well?

Copy link
Contributor

@YuriPlyakhin YuriPlyakhin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, it seems this xfail can be removed:

// XFAIL: arch-intel_gpu_pvc && igc-dev

// https://github.com/intel/llvm/issues/14826

.github/workflows/sycl-linux-precommit.yml Outdated Show resolved Hide resolved
.github/workflows/sycl-linux-precommit.yml Outdated Show resolved Hide resolved
@YuriPlyakhin
Copy link
Contributor

@uditagarwal97, I noticed some Joint Matrix tests are skipped. I believe, it is because some tests are still using "matrix" feature and it is not passed to lit. Is it possible to pass this parameter to lit for now, until I clean this up in tests?

@YuriPlyakhin I already pass --param gpu-intel-pvc=True LIT option for now (https://github.com/intel/llvm/pull/15308/files#diff-bcddf1bc08cdd8b2a69b2c952d9ccd3b3d5c1e5302b39f5780d3d3568cd36a6a). Do we need to pass some other LIT option as well?

@uditagarwal97 , yes, I provided details in comments. We need to pass also --param matrix=1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants