Ensure body is rewound #425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beanieboi
approved these changes
Jun 12, 2024
|
@ydah Can we merge this? |
|
@tt Do you need a release including this PR change sooner? If yes, we will release immediately. |
|
@ydah, that would be excellent. Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small change to always rewind the request body.
Rack::Request#POSTno longer does this in recent Rack versions. It was removed in rack/rack@42aff22.Rack::RewindableInput::Middlewareis likely going to be required for most users of this library.Committee requires more changes to be compatible with Rack 3.1.x. I'm adding a constraint so Bundler doesn't try to upgrade dependencies past what's supported.