Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): use tilde in typescript dependency #357

Merged
merged 1 commit into from
Jun 28, 2023

Conversation

rwaskiewicz
Copy link
Member

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Tests (npm test) were run locally and passed
  • Prettier (npm run prettier) was run locally and passed

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe): Deps

What is the current behavior?

GitHub Issue Number: N/A

What is the new behavior?

the motivation for this commit is that renovatebot keeps attempting to update ts to version 5.1.3, despite having a (assumed) valid renovate config. try using a tilde here.

Does this introduce a breaking change?

  • Yes
  • No

Testing

CI only

Other information

@rwaskiewicz rwaskiewicz marked this pull request as ready for review June 27, 2023 21:34
@rwaskiewicz rwaskiewicz requested a review from a team as a code owner June 27, 2023 21:34
Copy link
Member

@tanner-reits tanner-reits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Double-checked the renovate config and that looks good so not sure why it's trying to get bumped. Guess we can give this a go

the motivation for this commit is that renovatebot keeps attempting to
update ts to version 5.1.3, despite having a (assumed) valid renovate
config. try using a tilde here.
@rwaskiewicz rwaskiewicz force-pushed the rwaskiewicz/update-ts-install branch from bc8b759 to dc97f61 Compare June 28, 2023 17:58
@rwaskiewicz rwaskiewicz enabled auto-merge (squash) June 28, 2023 17:58
@rwaskiewicz rwaskiewicz merged commit 6da1018 into main Jun 28, 2023
4 checks passed
@rwaskiewicz rwaskiewicz deleted the rwaskiewicz/update-ts-install branch June 28, 2023 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants