Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): don't fail fast for build job #363

Merged
merged 3 commits into from
Jul 13, 2023

Conversation

rwaskiewicz
Copy link
Member

@rwaskiewicz rwaskiewicz commented Jun 30, 2023

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Tests (npm test) were run locally and passed
  • Prettier (npm run prettier) was run locally and passed

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

If one CI job fails, others may be cancelled without running to completion

GitHub Issue Number: N/A

What is the new behavior?

this commit prevents the build job from failing fast (i.e. if '2' in the
stencil_version matrix fails, the rest of the jobs will not fail). this
ought to allow us to root our stencil version-based errors more easily
if an error pertains to a single version

Does this introduce a breaking change?

  • Yes
  • No

Testing

ddeeb46 was temporarily added to this branch to add a little bit of chaos/random error throwing. No jobs were cancelled as a result of errors being thrown
Screenshot 2023-06-30 at 2 36 05 PM

Other information

@rwaskiewicz rwaskiewicz force-pushed the rwaskiewicz/ci-do-not-fail-fast branch from d7cb522 to ddeeb46 Compare June 30, 2023 18:34
@rwaskiewicz rwaskiewicz marked this pull request as ready for review June 30, 2023 18:37
@rwaskiewicz rwaskiewicz requested a review from a team as a code owner June 30, 2023 18:37
this commit prevents the build job from failing fast (i.e. if '2' in the
stencil_version matrix fails, the rest of the jobs will not fail). this
ought to allow us to root our stencil version-based errors more easily
if an error pertains to a single version
@rwaskiewicz rwaskiewicz force-pushed the rwaskiewicz/ci-do-not-fail-fast branch from 742d350 to ff93988 Compare July 13, 2023 13:17
@rwaskiewicz rwaskiewicz enabled auto-merge (squash) July 13, 2023 13:18
@rwaskiewicz rwaskiewicz merged commit efb2efc into main Jul 13, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants