chore(ci): don't fail fast for build job #363
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Please check if your PR fulfills the following requirements:
npm run build
) was run locally and any changes were pushednpm test
) were run locally and passednpm run prettier
) was run locally and passedPull request type
Please check the type of change your PR introduces:
What is the current behavior?
If one CI job fails, others may be cancelled without running to completion
GitHub Issue Number: N/A
What is the new behavior?
this commit prevents the build job from failing fast (i.e. if '2' in the
stencil_version matrix fails, the rest of the jobs will not fail). this
ought to allow us to root our stencil version-based errors more easily
if an error pertains to a single version
Does this introduce a breaking change?
Testing
ddeeb46 was temporarily added to this branch to add a little bit of chaos/random error throwing. No jobs were cancelled as a result of errors being thrown
![Screenshot 2023-06-30 at 2 36 05 PM](https://private-user-images.githubusercontent.com/1930213/250169759-d86f1b1d-506c-451f-8eb2-eb062db43403.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjYxNzA1NjksIm5iZiI6MTcyNjE3MDI2OSwicGF0aCI6Ii8xOTMwMjEzLzI1MDE2OTc1OS1kODZmMWIxZC01MDZjLTQ1MWYtOGViMi1lYjA2MmRiNDM0MDMucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDkxMiUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA5MTJUMTk0NDI5WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9NjZjODkyMzdlZTM1OWU4M2JiMDUxMzUwYjdjMjNlZGQ0YTcxMDQ1MjJmNjU3YmUyNDQzY2Q5NGY4MDcyMTVjMCZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.LsG3VUEqNBDfqYeYAIxgUb8bD8k_6jsvcycAsb4GGKM)
Other information