-
Notifications
You must be signed in to change notification settings - Fork 783
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
refactor(deno): remove deno from codebase (#3067)
remove deno from the codebase. narrow environment variables to only account for a Node-based environment an adr is included in this commit to justify the removal of deno from the codebase
- Loading branch information
1 parent
66d0476
commit 037b228
Showing
92 changed files
with
47 additions
and
13,576 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -20,7 +20,6 @@ coverage/ | |
|
||
/build/ | ||
/scripts/build/ | ||
!/scripts/build/deno-cache | ||
dist/ | ||
|
||
# submodule packages | ||
|
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,37 @@ | ||
# 13. deno-removal | ||
|
||
Date: 2021.09.16 | ||
|
||
## Status | ||
|
||
accepted | ||
|
||
## Context | ||
|
||
Deno support in Stencil has always been marked as 'experimental'. Throughout the feature's lifespan, the current team | ||
has run into some form of issue or another. For a concrete example of such an issue, see | ||
[0010-deno-vendoring.md](./0010-deno-vendoring.md). | ||
|
||
The Stencil team revisited the capability and value associated with this functionality. The feature did not work in | ||
the latest version of Stencil, and the team has not been able to get any positive signal that this functionality is | ||
being used. | ||
|
||
## Decision | ||
|
||
Deno shall be removed from the Stencil codebase. However, the `sys` interface shall remain. | ||
|
||
Deno shall be removed from the Stencil site as a downloadable executable, and marked as having reached end of life. | ||
|
||
## Consequences | ||
|
||
The codebase may become easier to maintain. | ||
|
||
It is possible the PR in which Deno is removed may leave behind artifacts from the Deno implementation. This includes, | ||
but is not limited to: | ||
- Implementation details that are a result of the system handling both the node and Deno runtimes | ||
- Subtle breakages in the codebase in the event of global entities being mutated at build/runtime | ||
|
||
## Links | ||
|
||
- [0010-deno-vendoring.md](./0010-deno-vendoring.md) | ||
- [Deno End of Life PR](https://github.com/ionic-team/stencil-site/pull/764) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
15 changes: 0 additions & 15 deletions
15
scripts/build/deno-cache/deno_land_std_0_63_0__util_assert_ts.ts
This file was deleted.
Oops, something went wrong.
41 changes: 0 additions & 41 deletions
41
scripts/build/deno-cache/deno_land_std_0_63_0_encoding_base64_ts.ts
This file was deleted.
Oops, something went wrong.
106 changes: 0 additions & 106 deletions
106
scripts/build/deno-cache/deno_land_std_0_63_0_encoding_hex_ts.ts
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.