Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ComponentInterface should declare the componentShouldUpdate function #2489

Closed
ghingis opened this issue Jun 5, 2020 · 0 comments · Fixed by #2505
Closed

ComponentInterface should declare the componentShouldUpdate function #2489

ghingis opened this issue Jun 5, 2020 · 0 comments · Fixed by #2505
Labels

Comments

@ghingis
Copy link

ghingis commented Jun 5, 2020

Stencil version:

 up to @stencil/core@1.15.0-2

I'm submitting a:
[ ] bug report
[x] feature request
[ ] support request

Current behavior:
ComponentInterface does not declare the componentShouldUpdate function as an implementable function

Expected behavior:
ComponentInterface should declare the componentShouldUpdate as an implementable function

Steps to reproduce:

  • create a component that implements the ComponentInterface from @stencil/core
  • check the functions that you can implement from ComponentInterface

Other information:
The code should be located at:
src\declarations\stencil-public-runtime.ts
L:375 - L:427

@ionitron-bot ionitron-bot bot added the triage label Jun 5, 2020
tricki added a commit to tricki/stencil that referenced this issue Jun 11, 2020
Add `componentShouldUpdate` docs to `ComponentInterface`

fixes ionic-team#2489
manucorporat pushed a commit that referenced this issue Jun 15, 2020
Add `componentShouldUpdate` docs to `ComponentInterface`

fixes #2489
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant