Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: test exec breaks after updating from 4.11 to 4.12 - node:crypto #5358

Closed
3 tasks done
deleonio opened this issue Feb 13, 2024 · 9 comments · Fixed by #5369
Closed
3 tasks done

bug: test exec breaks after updating from 4.11 to 4.12 - node:crypto #5358

deleonio opened this issue Feb 13, 2024 · 9 comments · Fixed by #5369

Comments

@deleonio
Copy link

deleonio commented Feb 13, 2024

Prerequisites

Stencil Version

4.12.x

Current Behavior

We receive exceptions when executing the stencil tests.

Expected Behavior

We receive no exception when executing the stencil tests.

System Info

    System: node 20.9.0
    Platform: darwin (23.2.0)
   CPU Model: Intel(R) Core(TM) i7-9750H CPU @ 2.60GHz (12 cpus)
    Compiler: /Users/***/Workspace/kolibri/lib/node_modules/.pnpm/@stencil+core@4.12.2/node_modules/@stencil/core/compiler/stencil.js
       Build: 1707755243
     Stencil: 4.12.2 🎯
  TypeScript: 5.3.3
      Rollup: 2.56.3
      Parse5: 7.1.2
      jQuery: 4.0.0-pre
      Terser: 5.27.0

Steps to Reproduce

One-line command:

pnpm clean && pnpm i && pnpm i @stencil/core@4.11.0 && pnpm test && pnpm i @stencil/core@4.12.2 && pnpm test
  1. Clone the repository: git clone https://github.com/deleonio/kolibri-library.git
  2. Install the dependencies: pnpm i
  3. Install Stencil to version 4.11: pnpm i @stencil/core@4.11.0
  4. Run the tests: pnpm test
  5. Update Stencil to version 4.12: pnpm i @stencil/core@4.12.2
  6. Run the tests again: pnpm test

Code Reproduction URL

git clone https://github.com/deleonio/kolibri-library.git

Additional Information

No response

@ionitron-bot ionitron-bot bot added the triage label Feb 13, 2024
@deleonio deleonio changed the title bug: test exec breaks after updating from version 4.11 to 4.12 - exception node:crypto bug: test exec breaks after updating from 4.11 to 4.12 - node:crypto Feb 13, 2024
@rwaskiewicz rwaskiewicz self-assigned this Feb 13, 2024
@rwaskiewicz
Copy link
Member

Hey @deleonio 👋

Can you please provide a more minimal reproduction for the team to take a look at? Kolibri is too large of a project for the team to delve into and try to understand. Thanks!

@rwaskiewicz rwaskiewicz added the ionitron: needs reproduction This PR or Issue does not have a reproduction case URL label Feb 13, 2024
Copy link

ionitron-bot bot commented Feb 13, 2024

Thanks for the issue! This issue has been labeled as needs reproduction. This label is added to issues that need a code reproduction.

Please reproduce this issue in an Stencil starter component library and provide a way for us to access it (GitHub repo, StackBlitz, etc). Without a reliable code reproduction, it is unlikely we will be able to resolve the issue, leading to it being closed.

If you have already provided a code snippet and are seeing this message, it is likely that the code snippet was not enough for our team to reproduce the issue.

For a guide on how to create a good reproduction, see our Contributing Guide.

@rwaskiewicz rwaskiewicz removed their assignment Feb 13, 2024
@ionitron-bot ionitron-bot bot removed the triage label Feb 13, 2024
@deleonio
Copy link
Author

Here is a minimal sample for reproduction: https://github.com/deleonio/kolibri-library

@rwaskiewicz
Copy link
Member

@deleonio
Thanks! Is that reproduction public? GitHub returns a 404 when I try to access it

@deleonio
Copy link
Author

The repo is now public, sorry.

alicewriteswrongs added a commit that referenced this issue Feb 15, 2024
This fixes an issue where this couldn't be resolved in some cases.

fixes #5358
alicewriteswrongs added a commit that referenced this issue Feb 15, 2024
This fixes an issue where this couldn't be resolved in some cases.

fixes #5358
@alicewriteswrongs
Copy link
Contributor

Hey @deleonio, I was just able to take a look at this and found a fix which seems to fix things in your repro case locally for me. I just published a dev build containing the fix, if you wouldn't mind trying it out to confirm it fixes the issue!

You can do that like this:

npm i @stencil/core@4.12.2-dev.1708019928.b3d5775

@rwaskiewicz rwaskiewicz added Bug: Validated This PR or Issue is verified to be a bug within Stencil and removed ionitron: needs reproduction This PR or Issue does not have a reproduction case URL Bug: Validated This PR or Issue is verified to be a bug within Stencil labels Feb 15, 2024
@deleonio
Copy link
Author

@alicewriteswrongs, thank you very much!

It works in the reproduction Repo and also in our large monorepo Public UI / KoliBri for the German gov.

If there is anything I can do for Stencil, please let me know. ❤️

@alicewriteswrongs
Copy link
Contributor

Awesome, thanks for giving that a try! I'll get that merged and we'll ping here when it's released

github-merge-queue bot pushed a commit that referenced this issue Feb 16, 2024
…o` (#5369)

This fixes an issue where this couldn't be resolved in some cases.

fixes #5358
@christian-bromann
Copy link
Member

A fix for this has been published in v4.12.3.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants