Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attribute ping is missing on AnchorHTMLAttributes #5751

Closed
3 tasks done
janerikmai opened this issue May 10, 2024 · 3 comments · Fixed by #5752
Closed
3 tasks done

Attribute ping is missing on AnchorHTMLAttributes #5751

janerikmai opened this issue May 10, 2024 · 3 comments · Fixed by #5752
Labels
Bug: Validated This PR or Issue is verified to be a bug within Stencil

Comments

@janerikmai
Copy link
Contributor

Prerequisites

Stencil Version

4.18.0

Current Behavior

Property 'ping' does not exist on type 'AnchorHTMLAttributes'.ts(2322) https://github.com/DefinitelyTyped/DefinitelyTyped/blob/18753976aad3956a963c3cafeeab6755b7c879a3/types/react/index.d.ts#L3105

Expected Behavior

    render() {
        return (
            <Host>
              <a href='https://www.google.com/' ping='https://www.google.com/tracking'>Anchor with ping attribute</a>

should be fine

System Info

System: node 20.11.1
    Platform: darwin (23.4.0)
   CPU Model: Apple M2 Pro (12 cpus)
    Compiler: ***/node_modules/@stencil/core/compiler/stencil.js
       Build: 1715010794
     Stencil: 4.18.0 🍵
  TypeScript: 5.4.5
      Rollup: 2.56.3
      Parse5: 7.1.2
      jQuery: 4.0.0-pre
      Terser: 5.31.0

Steps to Reproduce

import { Component, Element, Host,  h } from '@stencil/core';

@Component({
  tag: 'my-anchor',
  shadow: true
}) 
export class MyAnchor {
  @Element() host;

  render() {
    return (
      <Host>
        <a href='https://www.google.com/' ping='https://www.google.com/tracking'>Anchor with ping attribute</a>
      </Host>  
    )
  }
}

Code Reproduction URL

https://github.com

Additional Information

Screenshot 2024-05-10 at 14 37 24
should fix that...
@ionitron-bot ionitron-bot bot added the triage label May 10, 2024
@janerikmai janerikmai changed the title Attribute referrerPolicy is missing on AnchorHTMLAttributes Attribute ping is missing on AnchorHTMLAttributes May 10, 2024
janerikmai added a commit to janerikmai/stencil that referenced this issue May 10, 2024
@alicewriteswrongs alicewriteswrongs added the Bug: Validated This PR or Issue is verified to be a bug within Stencil label May 10, 2024
@ionitron-bot ionitron-bot bot removed the triage label May 10, 2024
@alicewriteswrongs
Copy link
Contributor

hey @janerikmai, was just able to confirm this! I can't ping!

Screenshot 2024-05-10 at 11 04 18 AM

I just labeled this so the team can take a look at your proposed fix in #5752, thanks for providing a reproduction and opening a fix!

@alicewriteswrongs
Copy link
Contributor

@janerikmai hey I just put that PR to merge, it will be included in our next release -- we'll ping here on this issue when that goes out!

Thanks for your contribution 🎉

@alicewriteswrongs
Copy link
Contributor

The fix for this issue has been released as a part of today's Stencil v4.18.1 release!

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug: Validated This PR or Issue is verified to be a bug within Stencil
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants