fix(compiler): no generate custom output #5951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christian-bromann
approved these changes
Aug 19, 2024
tanner-reits
approved these changes
Aug 26, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Do not generate custom output target on test fixes: ionic-team#5950
Sukaato
force-pushed
the
fix/do-not-generated-custom-on-test
branch
from
811dfe2
to
db661ab
Compare
|
CI / Unit Tests / (windows-latest.22) failed, but it is not related to my commit i guess. |
Unfortunately we haven't had the chance to identify the root cause of these flakes in our pipelines. I just re-ran the failing test and will go ahead and merge once passing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not generate custom output target on test
fixes: #5950
What is the current behavior?
GitHub Issue Number: #5950
What is the new behavior?
No generating the custom output target on test build
Documentation
Does this introduce a breaking change?
Testing
Manual testing
Other information