fix(compiler): allow attribute & reflect values on props w/ non JS primitives #5958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the current behavior?
Stencil ignores setting the
attributeandreflectvalues when transforming@Prop()decorators if their resolved types don't resolve to a JS primitive (string, number, etc.).GitHub Issue Number: #5618
What is the new behavior?
Stencil will now set the
attributeandreflectvalues regardless of the resolved type. This was they are always present in the generateddocs-json.Documentation
Does this introduce a breaking change?
Testing
Verified the expected behavior with the reproduction case, and updated unit test cases where the previous behavior was checked
Other information
There may be some repercussions to this change beyond what we can foresee, so we'll keep an eye on feedback once this is released if there are unwanted consequences