Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Module attributes break highlighting #61

Closed
varon opened this issue Jun 17, 2024 · 2 comments · Fixed by #63
Closed

Module attributes break highlighting #61

varon opened this issue Jun 17, 2024 · 2 comments · Fixed by #63

Comments

@varon
Copy link
Contributor

varon commented Jun 17, 2024

Describe the bug

When adding an attribute to a module, it tends to break and mess with the highlighting inside of it. This probably is due to the fact that modules aren't expected to have attributes in the grammar?

To Reproduce
view

/// Some documentation comment here
[<RequireQualifiedAccess>]
module internal Some.Qualified.ModuleName

open System
open System.Collections.Generic

In the above, the open System highlights incorrectly.
Nsidorenco added a commit that referenced this issue Jun 17, 2024
@Nsidorenco
fix: allow top-level module attributes
e072088 
Closes #61
@Nsidorenco
Copy link
Contributor

Good catch!

@Nsidorenco Nsidorenco mentioned this issue Jun 17, 2024
Merged
Nsidorenco added a commit that referenced this issue Jun 17, 2024
@Nsidorenco
fix: allow top-level module attributes (#63)
09b02eb 
Closes #61
@varon
Copy link
Contributor Author

varon commented Jun 17, 2024

Thanks - absolutely legend on the speed of the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: allow top-level module attributes ionide/tree-sitter-fsharp
2 participants
@varon @Nsidorenco