[ioctl] Build hdwallet derive command line into new ioctl #3418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR will continue after #3283 merged. |
huof6829
reviewed
May 31, 2022
combine hdwalletderive & hdwalletexport code and create ExportHdwallet client interface
huof6829
reviewed
Jun 2, 2022
huof6829
reviewed
Jun 2, 2022
Codecov Report
@@ Coverage Diff @@
## master #3418 +/- ##
==========================================
+ Coverage 75.08% 75.21% +0.13%
==========================================
Files 244 244
Lines 22546 22556 +10
==========================================
+ Hits 16928 16965 +37
+ Misses 4694 4666 -28
- Partials 924 925 +1
Continue to review full report at Codecov.
|
huof6829
reviewed
Jun 27, 2022
huof6829
reviewed
Jun 27, 2022
huof6829
approved these changes
Jun 29, 2022
Liuhaai
reviewed
Jun 29, 2022
| @@ -160,7 +160,7 @@ func PrivateKeyFromSigner(client ioctl.Client, cmd *cobra.Command, signer, passw | |||
| if err != nil { | |||
| return nil, errors.Wrap(err, "invalid HDWallet key format") | |||
| } | |||
There was a problem hiding this comment.
I guess you're talking about HdwalletMnemonic.
The main reason is that we don't want to expose hdwalletConfigFile, so we add it in client struct, which makes all the related function also needs to be inside the client interface.
CoderZhi
approved these changes
Jun 30, 2022
pocockn
added a commit
to pocockn/iotex-core
that referenced
this pull request
Jul 4, 2022
* upstream/master: (24 commits) account type with zero init nonce (iotexproject#3387) [api] Separate Server and Server Handler (iotexproject#3485) [ioctl] Build hdwallet derive command line into new ioctl (iotexproject#3418) [ioctl] Build hdwallet create command line into new ioctl (iotexproject#3470) [makefile] add go mod tidy (iotexproject#3471) [api] update chain metrics (iotexproject#3484) remove config.EVMNetworkID() (iotexproject#3460) [filedao] remove checkMasterChainDBFile() (iotexproject#3463) [api] add crashlog (iotexproject#3456) [api] Move generateBlockMeta to grpcserver.go (iotexproject#3303) [ioctl] Build action hash command line into new ioctl (iotexproject#3425) [ioctl] Build hdwallet export command line into new ioctl (iotexproject#3423) [ioctl] Refactor nodereward command in new ioctl (iotexproject#3416) [ioctl] Cleanup TestNewNodeDelegateCmd (iotexproject#3421) [blockchain] Remove BoltDBDaoOption (iotexproject#3465) remove InMemDaoOption (iotexproject#3464) [action] add evm london test (iotexproject#3402) [ioctl] create main for ioctl/newcmd (iotexproject#3296) [ioctl] Build block bucket command line into new ioctl (iotexproject#3386) [ioctl] Build hdwallet import command line into new ioctl (iotexproject#3419) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactor
hdwalletderivecommand in newioctl, with the following note.Fixes #3282
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist: