[pkg] fix deferring unsafe method "Close" on type "*os.File" #3548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3548 +/- ##
==========================================
- Coverage 75.43% 74.06% -1.38%
==========================================
Files 247 253 +6
Lines 22845 23327 +482
==========================================
+ Hits 17233 17277 +44
- Misses 4685 5124 +439
+ Partials 927 926 -1
|
dustinxie
reviewed
Jul 14, 2022
| if err != nil { | ||
| return err | ||
| } | ||
| defer f.Close() |
There was a problem hiding this comment.
can you check why security scan considers f.Close() as "unsafe method"? does it mean the error is not checked? like you need to:
defer func() {
return f.Close()
}
There was a problem hiding this comment.
error is skipped by defer f.Close(). it's unsafe. error should return.
defer func() error { return f.Close() }
or return f.Close() at the end of processing is both ok
There was a problem hiding this comment.
i see, so should check/catch the error inside defer
if return f.Close() at the end, also need to handle f.Close() in L42 and L45, so defer is better
There was a problem hiding this comment.
although current code is acceptable, you could find a new way to improve it
dustinxie
reviewed
Jul 18, 2022
pkg/recovery/recovery.go
Outdated
| } | ||
| if err = f.Close(); err != nil { | ||
| log.S().Errorf("crashlog: close heap profile error: %v", err) | ||
| return |
dustinxie
reviewed
Jul 18, 2022
ioctl/doc/doc.go
Outdated
| defer f.Close() | ||
|
|
||
| defer func() error { | ||
| return f.Close() |
There was a problem hiding this comment.
this just run f.Close() and return from defer, it does not return the actual error, need to assign the error inside defer, like
defer func() {
err = f.Close()
}
and return err at the end
Liuhaai
approved these changes
Jul 19, 2022
CoderZhi
approved these changes
Jul 19, 2022
pocockn
added a commit
to pocockn/iotex-core
that referenced
this pull request
Jul 20, 2022
…task/set-config * 'task/set-config' of github.com:pocockn/iotex-core: [test] Disable workingset cache in the benchmark test (iotexproject#3558) [pkg] fix deferring unsafe method "Close" on type "*os.File" (iotexproject#3548) [action] Refactor handleTransfer() (iotexproject#3557) Add MinVersion in tls.Config (iotexproject#3562) [ioctl] Modify file permission as 0600 (iotexproject#3563) [httputil] add ReadHeaderTimeout (iotexproject#3550) [staking] unexport namespace (iotexproject#3551) move chanid metrics to chainservice (iotexproject#3544) [ioctl] fix log entries created from user input (iotexproject#3546) add log in rolldposctx (iotexproject#3553) fix uncontrolled data used in path expression (iotexproject#3547) [api] impl. TestGrpcServer_GetServerMeta (iotexproject#3559) [ioctl] Build action command line into new ioctl (iotexproject#3472) fix potential file inclusion via variable (iotexproject#3549)
pocockn
added a commit
to pocockn/iotex-core
that referenced
this pull request
Jun 3, 2023
* upstream/master: (45 commits) Task: Get config cmd (iotexproject#3552) [ioctl] fix Errors unhandled (iotexproject#3567) fix dir permission and file inclusion (iotexproject#3566) [test] Disable workingset cache in the benchmark test (iotexproject#3558) [pkg] fix deferring unsafe method "Close" on type "*os.File" (iotexproject#3548) [action] Refactor handleTransfer() (iotexproject#3557) Add MinVersion in tls.Config (iotexproject#3562) [ioctl] Modify file permission as 0600 (iotexproject#3563) [httputil] add ReadHeaderTimeout (iotexproject#3550) [staking] unexport namespace (iotexproject#3551) move chanid metrics to chainservice (iotexproject#3544) [ioctl] fix log entries created from user input (iotexproject#3546) add log in rolldposctx (iotexproject#3553) fix uncontrolled data used in path expression (iotexproject#3547) [api] impl. TestGrpcServer_GetServerMeta (iotexproject#3559) [ioctl] Build action command line into new ioctl (iotexproject#3472) fix potential file inclusion via variable (iotexproject#3549) [ioctl] Incorrect conversion between integer types (iotexproject#3522) [action] fix incorrect conversion between integer types (iotexproject#3545) [test] fix TestLoadBlockchainfromDB (iotexproject#3521) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fix gosec error: Deferring unsafe method "Close" on type "*os.File"
Fixes #3532
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist: