Process batch serialise concurrently

action/action_deserializer.go

@@ -14,7 +14,6 @@ import "github.com/iotexproject/iotex-proto/golang/iotextypes"
 // Currently the parameter is EVM network ID for tx in web3 format, it is called like
 //
 // act, err := (&Deserializer{}).SetEvmNetworkID(id).ActionToSealedEnvelope(pbAction)
-//
 type Deserializer struct {
 	evmNetworkID uint32
 }

action/protocol/execution/evm/evm.go

@@ -341,7 +341,7 @@ func getChainConfig(g genesis.Blockchain, height uint64, id uint32) *params.Chai
 	return &chainConfig
 }
 
-//Error in executeInEVM is a consensus issue
+// Error in executeInEVM is a consensus issue
 func executeInEVM(ctx context.Context, evmParams *Params, stateDB *StateDBAdapter, g genesis.Blockchain, gasLimit uint64, blockHeight uint64) ([]byte, uint64, uint64, string, iotextypes.ReceiptStatus, error) {
 	remainingGas := evmParams.gas
 	if err := securityDeposit(evmParams, stateDB, gasLimit); err != nil {

action/protocol/vote/probationlist.go

@@ -15,7 +15,7 @@ import (
 	"github.com/iotexproject/iotex-proto/golang/iotextypes"
 )
 
-//ProbationList defines a map where key is candidate's name and value is the counter which counts the unproductivity during probation epoch.
+// ProbationList defines a map where key is candidate's name and value is the counter which counts the unproductivity during probation epoch.
 type ProbationList struct {
 	ProbationInfo map[string]uint32
 	IntensityRate uint32

actpool/actpool.go

@@ -361,9 +361,9 @@ func (ap *actPool) validate(ctx context.Context, selp action.SealedEnvelope) err
 	return nil
 }
 
-//======================================
+// ======================================
 // private functions
-//======================================
+// ======================================
 func (ap *actPool) enqueueAction(ctx context.Context, addr address.Address, act action.SealedEnvelope, actHash hash.Hash256, actNonce uint64) error {
 	span := tracer.SpanFromContext(ctx)
 	defer span.End()

blockchain/block/block_deserializer.go

@@ -21,7 +21,6 @@ import (
 //
 // blk, err := (&Deserializer{}).SetEvmNetworkID(id).FromBlockProto(pbBlock)
 // blk, err := (&Deserializer{}).SetEvmNetworkID(id).DeserializeBlock(buf)
-//
 type Deserializer struct {
 	evmNetworkID uint32
 }

blockchain/blockchain.go

@@ -399,7 +399,7 @@ func (bc *blockchain) MintNewBlock(timestamp time.Time) (*block.Block, error) {
 	return &blk, nil
 }
 
-//  CommitBlock validates and appends a block to the chain
+// CommitBlock validates and appends a block to the chain
 func (bc *blockchain) CommitBlock(blk *block.Block) error {
 	bc.mu.Lock()
 	defer bc.mu.Unlock()

consensus/scheme/rolldpos/endorsementmanager.go

@@ -31,7 +31,7 @@ var (
 	_statusKey            = []byte("status")
 )
 
-//EndorsedByMajorityFunc defines a function to give an information of consensus status
+// EndorsedByMajorityFunc defines a function to give an information of consensus status
 type EndorsedByMajorityFunc func(blockHash []byte, topics []ConsensusVoteTopic) bool
 
 type endorserEndorsementCollection struct {

db/batch/batch_impl.go

@@ -96,19 +96,30 @@ func (b *baseKVStoreBatch) Entry(index int) (*WriteInfo, error) {
 func (b *baseKVStoreBatch) SerializeQueue(serialize WriteInfoSerialize, filter WriteInfoFilter) []byte {
 	b.mutex.Lock()
 	defer b.mutex.Unlock()
-	// 1. This could be improved by being processed in parallel
-	// 2. Digest could be replaced by merkle root if we need proof
-	bytes := make([]byte, 0)
+	// 1. Digest could be replaced by merkle root if we need proof
+	bytesChan := make(chan []byte, len(b.writeQueue))
+	wg := sync.WaitGroup{}
+	wg.Add(len(b.writeQueue))
 	for _, wi := range b.writeQueue {
-		if filter != nil && filter(wi) {
-			continue
-		}
-		if serialize != nil {
-			bytes = append(bytes, serialize(wi)...)
-		} else {
-			bytes = append(bytes, wi.Serialize()...)
-		}
+		go func(info *WriteInfo) {
+			if filter != nil && filter(info) {
+				return
+			}
+			if serialize != nil {
+				bytesChan <- serialize(info)
+			} else {
+				bytesChan <- info.Serialize()
+			}
+			wg.Done()
+		}(wi)
 	}
+	wg.Wait()
+
+	bytes := make([]byte, 0)
+	for itemBytes := range bytesChan {
+		bytes = append(bytes, itemBytes...)
+	}
+
 	return bytes
 }
 

db/batch/batch_impl_test.go

@@ -49,7 +49,7 @@ func TestBaseKVStoreBatch(t *testing.T) {
 	require.Equal(0.5, p)
 
 	// test serialize/translate
-	require.True(bytes.Equal([]byte{0, 110, 115, 1, 110, 115}, b.SerializeQueue(nil, nil)))
+	require.True(bytes.Equal([]byte{1, 110, 115, 0, 110, 115}, b.SerializeQueue(nil, nil)))
 	require.True(bytes.Equal([]byte{}, b.SerializeQueue(nil, func(wi *WriteInfo) bool {
 		return wi.Namespace() == "ns"
 	})))

ioctl/cmd/action/stake2.go

@@ -38,7 +38,7 @@ var (
 
 var _stake2AutoStake bool
 
-//Stake2Cmd represent stake2 command
+// Stake2Cmd represent stake2 command
 var Stake2Cmd = &cobra.Command{
 	Use:   "stake2",
 	Short: config.TranslateInLang(_stake2CmdShorts, config.UILanguage),

ioctl/cmd/action/xrc20.go

@@ -42,7 +42,7 @@ var (
 	}
 )
 
-//Xrc20Cmd represent xrc20 standard command-line
+// Xrc20Cmd represent xrc20 standard command-line
 var Xrc20Cmd = &cobra.Command{
 	Use:   "xrc20",
 	Short: config.TranslateInLang(_xrc20CmdShorts, config.UILanguage),

tools/executiontester/blockchain/erc721_token.go

@@ -53,7 +53,6 @@ func (f *erc721Token) CreateToken(tokenid, creditor string) (string, error) {
 	return h, nil
 }
 
-//
 func (f *erc721Token) Transfer(token, sender, prvkey, receiver string, tokenid string) (string, error) {
 	TokenID, ok := new(big.Int).SetString(tokenid, 10)
 	if !ok {