Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[actpool] validation for blobtx #4367

Merged
merged 5 commits into from
Sep 19, 2024
Merged

Conversation

envestcc
Copy link
Member

Description

There are many differences between Blob-tx and regular tx, requiring different validation rules to ensure the correctness of transactions while maintaining program performance.

Based on #4366

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • [] make test
  • [] fullsync
  • [] Other test (please specify)

Test Configuration:

  • Firmware version:
  • Hardware:
  • Toolchain:
  • SDK:

Checklist:

  • [] My code follows the style guidelines of this project
  • [] I have performed a self-review of my code
  • [] I have commented my code, particularly in hard-to-understand areas
  • [] I have made corresponding changes to the documentation
  • [] My changes generate no new warnings
  • [] I have added tests that prove my fix is effective or that my feature works
  • [] New and existing unit tests pass locally with my changes
  • [] Any dependent changes have been merged and published in downstream modules

@envestcc envestcc marked this pull request as draft August 15, 2024 23:54
@envestcc envestcc force-pushed the actpool_blob branch 2 times, most recently from 507d8be to dbdf68b Compare August 21, 2024 14:48
@envestcc envestcc marked this pull request as ready for review August 21, 2024 14:49
actpool/actpool.go Outdated Show resolved Hide resolved
actpool/actpool.go Outdated Show resolved Hide resolved
actpool/actpool.go Outdated Show resolved Hide resolved
actpool/actqueue.go Outdated Show resolved Hide resolved
actpool/actqueue.go Outdated Show resolved Hide resolved
actpool/actqueue.go Outdated Show resolved Hide resolved
actpool/actqueue.go Outdated Show resolved Hide resolved
actpool/actqueue.go Outdated Show resolved Hide resolved
actpool/queueworker.go Outdated Show resolved Hide resolved
Copy link

sonarcloud bot commented Sep 19, 2024

@envestcc envestcc merged commit ef61b43 into iotexproject:master Sep 19, 2024
3 checks passed
@envestcc envestcc deleted the actpool_blob branch September 19, 2024 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants