Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: helia-vue example #24

Merged
merged 25 commits into from
Apr 5, 2023

Conversation

polus-arcticus
Copy link
Contributor

@polus-arcticus polus-arcticus commented Apr 1, 2023

adds and example built on vue that hits the unixfs api.

Note: Playwright was an option built into the npm init vue@latest not sure how the ci is going to handle it
on CI: build is failing due too

> helia-vue@0.0.0 test
> vite build && playwright test

vite v4.2.1 building for production...
transforming...
✓ 57 modules transformed.
✓ built in 901ms
[vite]: Rollup failed to resolve import "interface-datastore/key" from "/home/runner/work/helia-examples/helia-examples/node_modules/datastore-core/dist/src/shard.js".
This is most likely unintended because it can break your application at runtime.
If you do want to externalize this module explicitly add it to
`build.rollupOptions.external`
error during build:
Error: [vite]: Rollup failed to resolve import "interface-datastore/key" from "/home/runner/work/helia-examples/helia-examples/node_modules/datastore-core/dist/src/shard.js".
This is most likely unintended because it can break your application at runtime.
If you do want to externalize this module explicitly add it to
`build.rollupOptions.external`
    at onRollupWarning (file:///home/runner/work/helia-examples/helia-examples/node_modules/vite/dist/node/chunks/dep-79[8](https://github.com/ipfs-examples/helia-examples/actions/runs/4603481436/jobs/8133526694?pr=24#step:6:9)[9](https://github.com/ipfs-examples/helia-examples/actions/runs/4603481436/jobs/8133526694?pr=24#step:6:10)2de8.js:46368:19)
    at onwarn (file:///home/runner/work/helia-examples/helia-examples/node_modules/vite/dist/node/chunks/dep-79892de8.js:46[13](https://github.com/ipfs-examples/helia-examples/actions/runs/4603481436/jobs/8133526694?pr=24#step:6:14)8:13)
    at Object.onwarn (file:///home/runner/work/helia-examples/helia-examples/node_modules/vite/node_modules/rollup/dist/es/shared/node-entry.js:25[14](https://github.com/ipfs-examples/helia-examples/actions/runs/4603481436/jobs/8133526694?pr=24#step:6:15)9:13)
    at ModuleLoader.handleInvalidResolvedId (file:///home/runner/work/helia-examples/helia-examples/node_modules/vite/node_modules/rollup/dist/es/shared/node-entry.js:[23](https://github.com/ipfs-examples/helia-examples/actions/runs/4603481436/jobs/8133526694?pr=24#step:6:24)784:[26](https://github.com/ipfs-examples/helia-examples/actions/runs/4603481436/jobs/8133526694?pr=24#step:6:27))
    at file:///home/runner/work/helia-examples/helia-examples/node_modules/vite/node_modules/rollup/dist/es/shared/node-entry.js:23744:26
npm ERR! Lifecycle script `test` failed with error: 
npm ERR! Error: command failed 
npm ERR!   in workspace: helia-vue@0.0.0 
npm ERR!   at location: /home/runner/work/helia-examples/helia-examples/examples/helia-vue 
Error: Process completed with exit code 1.

which is strange is it builds both locally and on codesandbox, cant figure it out

@polus-arcticus polus-arcticus marked this pull request as ready for review April 4, 2023 02:57
@polus-arcticus polus-arcticus changed the title [WIP]: vue example helia-vue example Apr 4, 2023
@achingbrain achingbrain changed the title helia-vue example feat: helia-vue example Apr 4, 2023
Copy link
Contributor

@achingbrain achingbrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thanks! There was a bit of churn in the dependencies recently but that's passed now. I've tided up the linting a bit, but thanks for contributing this and for adding tests.

@achingbrain achingbrain merged commit 76a9325 into ipfs-examples:main Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants