This repository has been archived by the owner on Mar 10, 2020. It is now read-only.
feat: add methods for listing config profiles #1119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New method:
```javascript
Promise<Array<{ name, description }>> ipfs.config.profiles.list()
```
BREAKING CHANGE:
```javascript
Promise<{oldCfg, newCfg}> ipfs.config.profile(name, opts)
// is now
Promise<{old, new}> ipfs.config.profiles.apply(name, opts)
```
Possibly contentious;
Adds `callbackify` as a dependency, see ipfs/js-ipfs#2506
for discussion.
2 tasks
hugomrdias
approved these changes
Oct 4, 2019
src/config/profiles/list.js
Outdated
| timeout: options.timeout, | ||
| signal: options.signal, | ||
| headers: options.headers, | ||
| searchParams |
There was a problem hiding this comment.
just pass an object { 'stream-channels': true } ky will do the rest, no need to manually instantiate URLSearchParams
There was a problem hiding this comment.
I think I just copy/pasted that from ipfs.add..
There was a problem hiding this comment.
Hmm, you can only set strings or numbers as values if you use a plain object (e.g. no booleans), otherwise you get:
Error: The `searchParams` option must be either a string, `URLSearchParams` instance or an object with string and number values
There was a problem hiding this comment.
There was a problem hiding this comment.
Looks like they're going to fix this in ky@0.16.0
hugomrdias
approved these changes
Oct 4, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New method:
BREAKING CHANGE:
Possibly contentious:
Adds
callbackifyas a dependency, see ipfs/js-ipfs#2506 for discussion.Depends on: