Skip to content
This repository has been archived by the owner on Mar 10, 2020. It is now read-only.

feat: Add offset/length arguments to files.cat #734

Merged
merged 2 commits into from
Apr 24, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@
"is-stream": "^1.1.0",
"libp2p-crypto": "^0.13.0",
"lru-cache": "^4.1.2",
"multiaddr": "^4.0.0",
"multiaddr": "^5.0.0",
"multibase": "~0.4.0",
"multihashes": "~0.4.13",
"ndjson": "^1.5.0",
Expand Down Expand Up @@ -79,7 +79,7 @@
"go-ipfs-dep": "^0.4.14",
"gulp": "^3.9.1",
"hapi": "^17.3.1",
"interface-ipfs-core": "~0.64.0",
"interface-ipfs-core": "~0.64.2",
"ipfs": "~0.28.2",
"ipfsd-ctl": "~0.32.1",
"pre-commit": "^1.2.2",
Expand Down
7 changes: 6 additions & 1 deletion src/files/cat-pull-stream.js
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,12 @@ module.exports = (send) => {
}
}

send({ path: 'cat', args: hash, buffer: opts.buffer }, (err, stream) => {
const query = {
offset: opts.offset,
length: opts.length
}

send({ path: 'cat', args: hash, buffer: opts.buffer, qs: query }, (err, stream) => {
if (err) { return p.end(err) }

p.resolve(toPull(stream))
Expand Down
7 changes: 6 additions & 1 deletion src/files/cat-readable-stream.js
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,12 @@ module.exports = (send) => {
}
}

send({ path: 'cat', args: hash, buffer: opts.buffer }, (err, stream) => {
const query = {
offset: opts.offset,
length: opts.length
}

send({ path: 'cat', args: hash, buffer: opts.buffer, qs: query }, (err, stream) => {
if (err) { return pt.destroy(err) }

pump(stream, pt)
Expand Down
7 changes: 6 additions & 1 deletion src/files/cat.js
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,12 @@ module.exports = (send) => {
}
}

send({ path: 'cat', args: hash, buffer: opts.buffer }, (err, stream) => {
const query = {
offset: opts.offset,
length: opts.length
}

send({ path: 'cat', args: hash, buffer: opts.buffer, qs: query }, (err, stream) => {
if (err) { return callback(err) }

stream.pipe(bl((err, data) => {
Expand Down