This repository has been archived by the owner on Apr 29, 2020. It is now read-only.
feat: add KadDHT #100
Merged
feat: add KadDHT #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daviddias
commented
Apr 6, 2017
test/peer-routing.spec.js
Outdated
| describe('ring', () => { | ||
| it('nodeA.dial by Id to node C', (done) => { | ||
| nodeA.dial(nodeC.peerInfo.id, done) | ||
| }) |
There was a problem hiding this comment.
@dignifiedquire this simple test is failing with:
1) .peerRouting ring nodeA.dial by Id to node C:
Error
at LookupFailureError (/Users/koruza/code/js-libp2p-kad-dht/src/errors.js:7:1)
at waterfall (/Users/koruza/code/js-libp2p-kad-dht/src/index.js:454:23)
at nextTask (/Users/koruza/code/js-libp2p-kad-dht/node_modules/async/waterfall.js:28:14)
at /Users/koruza/code/js-libp2p-kad-dht/node_modules/async/waterfall.js:22:13
at apply (/Users/koruza/code/js-libp2p-kad-dht/node_modules/lodash/_apply.js:15:25)
at /Users/koruza/code/js-libp2p-kad-dht/node_modules/lodash/_overRest.js:32:12
at /Users/koruza/code/js-libp2p-kad-dht/node_modules/async/internal/onlyOnce.js:12:16
at setImmediate (/Users/koruza/code/js-libp2p-kad-dht/node_modules/multihashing-async/src/utils.js:8:7)
at Immediate.<anonymous> (/Users/koruza/code/js-libp2p-kad-dht/node_modules/async/internal/setImmediate.js:26:16)
at _combinedTickCallback (internal/process/next_tick.js:67:7)
at process._tickCallback (internal/process/next_tick.js:98:9)
Any clue?
There was a problem hiding this comment.
I've added some delay in order to ensure that the network is stabilized (which should not be required) and now I'm getting a different error. The peerRouting.findPeer is returning undefined as the peer and not a error in case of peer not found, making swarm to fail.
daviddias
commented
Apr 6, 2017
test/content-routing.spec.js
Outdated
| expect(providers).length.to.be.above(0) | ||
| done() | ||
| }) | ||
| }) |
There was a problem hiding this comment.
This one is yielding an empty array of providers immediately, meaning that it failing to find the peer and it is also not respective timeout.
daviddias
commented
Apr 6, 2017
test/peer-routing.spec.js
Outdated
|
|
||
| it('nodeA.dial by Id to node C', (done) => { | ||
| nodeA.dial(nodeC.peerInfo.id, done) | ||
| }) |
There was a problem hiding this comment.
#100 (comment) still persists
38 tasks
dignifiedquire
approved these changes
Apr 6, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.