feat: Implement unpin feature #233
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
banciur
force-pushed
the
banciur/unpin_feature
branch
from
fa6875e
to
d06835f
Compare
|
Now PR is broken as I did quick dirty fixes to match new web3 features of CF. If project is not dead ping me I can implement it in a proper way. |
|
@banciur hi! Sorry for taking so long. If you implement it, please mention me directly for review. |
|
@banciur Hey, would you be interested in still implementing this feature? Let me know! |
|
@websoftwares I think it could definitely be useful. My only concern is that it requires changes to all storage services and possibly dnslink too. |
|
@websoftwares @hacdias Yes this one would be bigger one. But at the end if you want to keep functiality you have to follow what is happening in cloudflare. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #131
Hello,
This is implementation of unpin feature for Cloudflare and ipfs node. I was a lazy and didn't create proper PR to
dnslink-cloudflarebut also I'm not sure what would be steps in this case.best regards
Tomek