Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: re-enable test coverage #1195

Merged
merged 6 commits into from
Oct 24, 2023
Merged

fix: re-enable test coverage #1195

merged 6 commits into from
Oct 24, 2023

Conversation

achingbrain
Copy link
Member

c8 has been released recently as has node so re-enable test coverage

@achingbrain
Copy link
Member Author

It's still broken. The CI jobs with coverage hang after completion then are killed after six hours.

@achingbrain achingbrain marked this pull request as draft February 21, 2023 07:04
@achingbrain
Copy link
Member Author

Refs: bcoe/c8#454

@laurentsenta laurentsenta mentioned this pull request Mar 7, 2023
Open
@achingbrain achingbrain mentioned this pull request Apr 4, 2023
Closed
@whizzzkid
Copy link
Contributor

@achingbrain can we get this merged? what needs to happen in order to validate this? I tested this on m1-mac and seems to work well.

You also might wanna remove the --cov arg from the command.

@whizzzkid whizzzkid mentioned this pull request Apr 4, 2023
Open
24 tasks
@achingbrain
Copy link
Member Author

can we get this merged?

Unfortunately coverage is still broken so not yet. See how CI on this PR is hanging on node jobs with coverage enabled.

You also might wanna remove the --cov arg from the command.

No, it's fine as it is. The workaround at the moment is to detect usage of coverage and print a warning to the user which explains why they aren't getting coverage.

Merging this PR will undo that and coverage will flow again, but it's blocked on bcoe/c8#454

Please do investigate alternatives in the meantime though.

@whizzzkid
Copy link
Contributor

@achingbrain got it, reading through the reported bug I don't think anyone knows what's causing it. It's hard to repro on local, GA being GA, I cancelled the workflow as it just hung.

@achingbrain achingbrain mentioned this pull request May 23, 2023
Merged
@achingbrain
fix: re-enable test coverage
79b384a 
c8 has been released recently as has node so re-enable test coverage
@achingbrain
test: test on lts and current
cbe463b
@achingbrain achingbrain marked this pull request as ready for review October 24, 2023 06:09
@achingbrain
Copy link
Member Author

Merging as this appears to be working now.

@achingbrain achingbrain merged commit 9b35013 into master Oct 24, 2023
18 checks passed
@achingbrain achingbrain deleted the fix/re-enable-test-coverage branch October 24, 2023 06:09
github-actions bot pushed a commit that referenced this pull request Oct 24, 2023
@semantic-release-bot
chore(release): 41.0.6 [skip ci]
90bf8a9 
## [41.0.6](v41.0.5...v41.0.6) (2023-10-24)

### Bug Fixes

* re-enable test coverage ([#1195](#1195)) ([9b35013](9b35013))
@achingbrain achingbrain restored the fix/re-enable-test-coverage branch October 25, 2023 06:23
achingbrain added a commit that referenced this pull request Oct 25, 2023
@achingbrain
Revert "fix: re-enable test coverage (#1195)"
7f5ab39 
This reverts commit 9b35013.
@achingbrain achingbrain mentioned this pull request Oct 25, 2023
Merged
achingbrain added a commit that referenced this pull request Oct 25, 2023
@achingbrain
fix: disable test coverage again (#1390)
cfeffc2 
This is not fixed, it's still causing larger builds to hang.

Reverts #1195
github-actions bot pushed a commit that referenced this pull request Oct 25, 2023
@semantic-release-bot
chore(release): 41.0.7 [skip ci]
6c36cfd 
## [41.0.7](v41.0.6...v41.0.7) (2023-10-25)

### Bug Fixes

* disable test coverage again ([#1390](#1390)) ([cfeffc2](cfeffc2)), closes [#1195](#1195)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@achingbrain @whizzzkid