Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: use Node16 module resolution #1434

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

achingbrain
Copy link
Member

@achingbrain achingbrain commented Dec 30, 2023

This is to support the "types" field in package.json to support modules that no longer have a root "types" field.

BREAKING CHANGE: Node16 module resolution ignores "types" and "typesVersions" in the package.json root when an exports map is found so requires "types" on every exports map entry instead

This is to support the `"types"` field in `package.json` to support
modules that no longer have a root `"types"` field.
@achingbrain achingbrain changed the title fix: use Node16 module resolution fix!: use Node16 module resolution Dec 30, 2023
achingbrain added a commit that referenced this pull request Jan 12, 2024
These deps don't work with `Node16` module resolution and PRs to
fix this have been open for ages.

Unblocks #1434
achingbrain added a commit that referenced this pull request Jan 12, 2024
These deps don't work with `Node16` module resolution and PRs to
fix this have been open for ages.

Unblocks #1434
github-actions bot pushed a commit that referenced this pull request Jan 12, 2024
## [42.1.3](v42.1.2...v42.1.3) (2024-01-12)

### Bug Fixes

* add missing @types/mdast dep ([#1445](#1445)) ([1a3dffc](1a3dffc))
* remove premove and merge-options ([#1449](#1449)) ([889b03a](889b03a)), closes [#1434](#1434)
Copy link
Member

@SgtPooki SgtPooki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we probably need to clean up quotations to be consistent

@achingbrain
Copy link
Member Author

We need to test this thoroughly before merging - every dep needs a types entry for every export

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants