refactor: remove badger, leveldb dependencies

[hsanjuan]

Boxo should not bring in such external dependencies only because some benchmarks that no one looks at anymore decided to use those deps. They have too many strings attached (i.e. badger doesn't build on some platforms etc).

[codecov]

Codecov Report

Merging #286 (6d06dfd) into main (268cad8) will decrease coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #286      +/-   ##
==========================================
- Coverage   47.88%   47.85%   -0.03%     
==========================================
  Files         273      273              
  Lines       33186    33186              
==========================================
- Hits        15890    15881       -9     
- Misses      15616    15627      +11     
+ Partials     1680     1678       -2     

see 10 files with indirect coverage changes

[lidel]

thank you! removing these deps sounds sensible

(:thought_balloon: we've pulled in a lot of things when we migrated repos, and i suspect we have a lot of deps that are only used in tests. these are more tricky to cleanup -- we run tests, but have no time to refactor to use less deps. probably something that needs to happen organically over time)

[Jorropo]

It may looks like we just use it as a KV store but this is wrong.
In multiple places we incorrectly implement a graph dB by listing and filtering keys.
This data store implement this by listing everything all the keys using go's map range iteration syntax which is not fast and O(N) based on the full size, not bucketed.
Also dht server store GiBs of data which is nice to do on disk.

[guseggert]

Are you having a concrete issue w/ this?

In general, consumers won't get this dependency in their build list--even if they directly use the dspinner package--since it's a test dependency.

It's my own review lol.

[hsanjuan]

Are you having a concrete issue w/ this?

In general, consumers won't get this dependency in their build list--even if they directly use the dspinner package--since it's a test dependency.

These rather superfluous tests make Badger appear in go.mod. That automatically directs dependency resolution when nothing overrides it, and I think can cause conflicts sometimes or cause importing old versions of things. This comes after ipfs/kubo#9839, although I think this could stay just fine (because it's just tests as you say). I just thought there's no need for boxo to pull in these deps at all in its dependency tree, particularly given the low value of doing so (it's not even tests, it's benchmarks).

[hacdias]

I think this is a reasonable change. I'm not very versed in how Go dependency management works, but assuming what @hsanjuan is true, this is likely a good change and should not affect anything as we're not really removing any tests.