fix(gateway): question marks in url.Path when redirecting #313
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes ipfs/kubo#9882, fixes ipfs/ipfs-companion#1201. I updated
toSubdomainURL
to use theurl.URL
struct from Go to build the final URL. The problem was thatrest
was the original, decoded,r.URL.Path
and it contains a?
. When Go parses it, it'd consider it as a query element, rightly so.Kubo PR: ipfs/kubo#9894