Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gw): missing return in error case #319

Merged
merged 1 commit into from
May 29, 2023
Merged

fix(gw): missing return in error case #319

merged 1 commit into from
May 29, 2023

Conversation

willscott
Copy link
Contributor

@willscott willscott commented May 29, 2023

@welcome

This comment was marked as resolved.

@willscott willscott changed the title return in error case Gateway handler: return in error case May 29, 2023
@codecov
Copy link

codecov bot commented May 29, 2023

Codecov Report

Merging #319 (f53d423) into main (8ec71db) will decrease coverage by 0.06%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #319      +/-   ##
==========================================
- Coverage   48.26%   48.21%   -0.06%     
==========================================
  Files         279      279              
  Lines       33538    33539       +1     
==========================================
- Hits        16187    16170      -17     
- Misses      15672    15687      +15     
- Partials     1679     1682       +3     
Impacted Files Coverage Δ
gateway/handler_defaults.go 36.42% <0.00%> (-0.25%) ⬇️

... and 13 files with indirect coverage changes

@lidel lidel changed the title Gateway handler: return in error case fix(gw): missing return in error case May 29, 2023
Copy link
Member

@lidel lidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@willscott willscott merged commit b8b39be into main May 29, 2023
@lidel lidel deleted the fix/gateway-panic branch May 29, 2023 19:56
lidel added a commit to ipfs-inactive/bifrost-gateway that referenced this pull request May 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bifrost panic in staging
2 participants