Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(gateway): support for order=, dups= parameters from IPIP-412 #370

Merged
merged 3 commits into from
Jul 24, 2023
Merged

feat(gateway): support for order=, dups= parameters from IPIP-412 #370

merged 3 commits into from
Jul 24, 2023

Commits on Jul 24, 2023

  1. feat(gateway): support for order=, dups= parameters from IPIP-412

    @hacdias
    hacdias committed Jul 24, 2023
    Configuration menu
    Copy the full SHA
    9ee4787 View commit details
    Browse the repository at this point in the history

  2. docs: ipip-412 changelog and better error messages

    @lidel @hacdias
    lidel authored and hacdias committed Jul 24, 2023
    Configuration menu
    Copy the full SHA
    0fa23f5 View commit details
    Browse the repository at this point in the history

  3. refactor: simplify processing of CarParams 

    - adds more type safety: DuplicateBlocksPolicy is no longer a pointer to
  bool, and together with DagOrder has an explicit *Unspecified state.
- removes passing pointer and reliance on mutation. now mutation
  happens only once, in buildCarParams func, where implicit defaults
  are set when order or dups are unspecified in the request
- moved car version validation and other parameter related logic
  into the same build funcs
- fixed a bug where ?format=car eclipsed params from Accept header
    @lidel @hacdias
    lidel authored and hacdias committed Jul 24, 2023
    Configuration menu
    Copy the full SHA
    c033fe5 View commit details
    Browse the repository at this point in the history