fix(gateway): include CORS on subdomain redirects #395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lidel
force-pushed
the
fix/http-options-on-subdomains
branch
from
47e4306
to
4735062
Compare
Codecov Report
@@ Coverage Diff @@
## main #395 +/- ##
==========================================
+ Coverage 51.37% 51.49% +0.12%
==========================================
Files 280 280
Lines 33443 33456 +13
==========================================
+ Hits 17181 17229 +48
+ Misses 14531 14491 -40
- Partials 1731 1736 +5
|
lidel
changed the title
lidel
added a commit
to ipfs/kubo
that referenced
this pull request
Jun 26, 2023
Depends on ipfs/boxo#395 Closes #9983
lidel
added a commit
to ipfs/kubo
that referenced
this pull request
Jun 26, 2023
Depends on ipfs/boxo#395 Closes #9983
lidel
added a commit
to ipfs/kubo
that referenced
this pull request
Jun 26, 2023
Depends on ipfs/boxo#395 Closes #9983
3 tasks
lidel
commented
Jun 27, 2023
Context: ipfs/kubo#9983 (comment) Closes #9983
hacdias
force-pushed
the
fix/http-options-on-subdomains
branch
from
4735062
to
072f6be
Compare
hacdias
approved these changes
Jun 27, 2023
hacdias
pushed a commit
to ipfs/kubo
that referenced
this pull request
Jun 27, 2023
Depends on ipfs/boxo#395 Closes #9983
Closed
hacdias
pushed a commit
that referenced
this pull request
Jun 29, 2023
Merged
hacdias
pushed a commit
that referenced
this pull request
Jun 29, 2023
(cherry picked from commit a87f9ed)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes regression introduced during one of the refactors since Kubo 0.20 and adds dedicated tests for preflight requests on both path and subdomain gateway.
Context: ipfs/kubo#9983 (comment)