Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[skip changelog] docs(readme): fix typo #424

Merged
merged 1 commit into from
Aug 8, 2023
Merged

[skip changelog] docs(readme): fix typo #424

merged 1 commit into from
Aug 8, 2023

Conversation

joaosa
Copy link
Contributor

@joaosa joaosa commented Aug 7, 2023

Read the readme and thought this was a typo.

@joaosa joaosa requested a review from a team as a code owner August 7, 2023 13:09
@welcome
Copy link

welcome bot commented Aug 7, 2023

Thank you for submitting this PR!
A maintainer will be here shortly to review it.
We are super grateful, but we are also overloaded! Help us by making sure that:

  • The context for this PR is clear, with relevant discussion, decisions
    and stakeholders linked/mentioned.

  • Your contribution itself is clear (code comments, self-review for the
    rest) and in its best form. Follow the code contribution
    guidelines

    if they apply.

Getting other community members to do a review would be great help too on complex PRs (you can ask in the chats/forums). If you are unsure about something, just leave us a comment.
Next steps:

  • A maintainer will triage and assign priority to this PR, commenting on
    any missing things and potentially assigning a reviewer for high
    priority items.

  • The PR gets reviews, discussed and approvals as needed.

  • The PR is merged by maintainers when it has been approved and comments addressed.

We currently aim to provide initial feedback/triaging within two business days. Please keep an eye on any labelling actions, as these will indicate priorities and status of your contribution.
We are very grateful for your contribution!

Copy link
Contributor

@Jorropo Jorropo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx

@Jorropo Jorropo enabled auto-merge (rebase) August 8, 2023 11:31
@codecov
Copy link

codecov bot commented Aug 8, 2023

Codecov Report

Merging #424 (9024922) into main (221dbc4) will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #424      +/-   ##
==========================================
- Coverage   49.75%   49.74%   -0.02%     
==========================================
  Files         248      248              
  Lines       29941    29941              
==========================================
- Hits        14898    14894       -4     
- Misses      13612    13615       +3     
- Partials     1431     1432       +1     

see 8 files with indirect coverage changes

@Jorropo Jorropo merged commit d4e6cd9 into ipfs:main Aug 8, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants