Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(bitswap): unify logger names #637

Merged
merged 2 commits into from
Jul 9, 2024
Merged

Conversation

gammazero
Copy link
Contributor

Use uniform pattern for logger naming: bitswap/pkgname

Slash delimiters are used to separate path segments used in logger names. This follows the convention used most commonly in other parts of boxo.

Use uniform pattern for logger naming: bitswap/pkgname

Slash delimiters are used to separate path segments used in logger names. This follows the conventios used most commonly in other parts of boxo.
@gammazero gammazero requested a review from a team as a code owner July 9, 2024 00:10
Copy link

codecov bot commented Jul 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.82%. Comparing base (733fa55) to head (82e77c0).

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #637      +/-   ##
==========================================
- Coverage   59.86%   59.82%   -0.05%     
==========================================
  Files         238      238              
  Lines       29976    29976              
==========================================
- Hits        17946    17932      -14     
- Misses      10416    10429      +13     
- Partials     1614     1615       +1     
Files Coverage Δ
bitswap/client/client.go 88.12% <ø> (-2.30%) ⬇️
bitswap/client/internal/getter/getter.go 81.81% <ø> (ø)
...tswap/client/internal/messagequeue/messagequeue.go 84.52% <ø> (-0.40%) ⬇️
bitswap/client/internal/peermanager/peermanager.go 91.72% <ø> (ø)
...ernal/providerquerymanager/providerquerymanager.go 87.45% <ø> (ø)
bitswap/client/internal/session/session.go 91.53% <ø> (+0.38%) ⬆️
.../internal/sessionpeermanager/sessionpeermanager.go 100.00% <ø> (ø)
bitswap/network/ipfs_impl.go 75.53% <ø> (-1.78%) ⬇️
bitswap/server/internal/decision/engine.go 90.90% <ø> (ø)
bitswap/server/server.go 65.21% <ø> (-0.29%) ⬇️

... and 4 files with indirect coverage changes

@lidel lidel changed the title Unify bitswap logger names refactor(bitswap): unify logger names Jul 9, 2024
Copy link
Member

@lidel lidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, cleaning up inconsistency in naming here should make it easier to follow what is happening.

@lidel lidel merged commit 2816b71 into main Jul 9, 2024
16 checks passed
@lidel lidel deleted the chore/unify-logger-names branch July 9, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants