Skip to content
This repository has been archived by the owner on Mar 9, 2022. It is now read-only.

add support for pinning mfs #116

Merged
merged 10 commits into from
Jan 28, 2021
Merged

add support for pinning mfs #116

merged 10 commits into from
Jan 28, 2021

Conversation

aschmahmann
Copy link
Contributor

@aschmahmann aschmahmann commented Dec 4, 2020

Copy link
Contributor

@petar petar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

remotepin.go Outdated Show resolved Hide resolved
remotepin.go Outdated Show resolved Hide resolved
Base automatically changed from petar/remotepin to master December 8, 2020 19:41
Copy link
Member

@lidel lidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

Note that even tho we use json:",omitempty" for Policies and MFS structs, theRemotePinningServiceMFSPolicy.Enable is bool, so ipfs pin remote service add will create an explicit Policies.MFS:

     "RemoteServices": {
      "testsrv": {
        "API": {
          "Endpoint": "https://testsrv.example.com",
           "Key": "secret"
         },
         "Policies": {
           "MFS": {
             "Enable": false
           }
         }
       }
     }

@aschmahmann aschmahmann merged commit 6b35ac3 into master Jan 28, 2021
@aschmahmann aschmahmann deleted the feat/pinmfs branch January 28, 2021 23:05
@aschmahmann aschmahmann mentioned this pull request Feb 18, 2021
73 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants