Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an option to pass URL to zap #101

Merged
merged 1 commit into from
Sep 4, 2020
Merged

Conversation

requilence
Copy link
Contributor

@requilence requilence commented Aug 10, 2020

This may be very useful to pass the logs to some external services like graylog alongside with the stdout/file
Scheme handlers can be registered via zap.RegisterSink

@welcome
Copy link

welcome bot commented Aug 10, 2020

Thank you for submitting this PR!
A maintainer will be here shortly to review it.
We are super grateful, but we are also overloaded! Help us by making sure that:

  • The context for this PR is clear, with relevant discussion, decisions
    and stakeholders linked/mentioned.

  • Your contribution itself is clear (code comments, self-review for the
    rest) and in its best form. Follow the code contribution
    guidelines

    if they apply.

Getting other community members to do a review would be great help too on complex PRs (you can ask in the chats/forums). If you are unsure about something, just leave us a comment.
Next steps:

  • A maintainer will triage and assign priority to this PR, commenting on
    any missing things and potentially assigning a reviewer for high
    priority items.

  • The PR gets reviews, discussed and approvals as needed.

  • The PR is merged by maintainers when it has been approved and comments addressed.

We currently aim to provide initial feedback/triaging within two business days. Please keep an eye on any labelling actions, as these will indicate priorities and status of your contribution.
We are very grateful for your contribution!

@aschmahmann
Copy link
Contributor

It seems like there are probably many parameters that could be passed through from go-log to zap, perhaps we should just allow taking a zap instance?

WDYT @Kubuxu @lanzafame

@Kubuxu
Copy link
Member

Kubuxu commented Aug 14, 2020

@aschmahmann the issue is how you initi it in safe way.

@aschmahmann
Copy link
Contributor

@Kubuxu are you happy merging this PR as is or do you have any concerns?

Copy link
Member

@Kubuxu Kubuxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge it. If we figure out anything better we will have to break al of the user interfaces again.

@Kubuxu Kubuxu merged commit 4f34608 into ipfs:master Sep 4, 2020
@Stebalien Stebalien mentioned this pull request May 11, 2021
27 tasks
@aschmahmann aschmahmann mentioned this pull request May 14, 2021
71 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants