enable configuring several log outputs #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The general design makes sense. |
Kubuxu
reviewed
Jun 24, 2020
setup.go
Outdated
| @@ -263,5 +264,50 @@ func configFromEnv() Config { | |||
| cfg.Stderr = false | |||
| } | |||
|
|
|||
| output := os.Getenv(envLoggingOutput) | |||
| //TODO: fix lanzafame's super lazy impl... | |||
There was a problem hiding this comment.
Yeah, strings.Split is in order here.
Stebalien
approved these changes
Jun 25, 2020
setup.go
Outdated
| case "stderr": | ||
| cfg.Stderr = true | ||
| case "file": | ||
| cfg.File = os.Getenv(envLoggingFile) |
Stebalien
approved these changes
Jun 25, 2020
27 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new environment variable that allows a user to enable several log outputs for a logger. The env var is
GOLOG_OUTPUTand takes a string of outputs concatenated by+similar to how theStandardOutputdirective works in systems. An example value would befile+stderrwhich ifGOLOG_FILEwas set, would log to both the file and stderr.