Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use ipld-explorer-components@7.0.2 #2257

Conversation

SgtPooki
Copy link
Member

@SgtPooki SgtPooki commented Sep 6, 2024

  • chore: update ipld-explorer-components
  • chore: use ipld-explorer-components@7.0.1

@SgtPooki SgtPooki changed the title chore: use ipld-explorer-components@7.0.1 chore: use ipld-explorer-components@7.0.2 Sep 11, 2024
Copy link
Member Author

@SgtPooki SgtPooki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

self review and left some explainer comments

test/e2e/explore.test.js Outdated Show resolved Hide resolved
@@ -119,19 +138,20 @@ test.describe('Explore screen', () => {
})

test('should open dag-pb', async ({ page }) => {
test.setTimeout(60000)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the update of kubo-rpc-client, ipfsd-ctl, and @helia/http and underlying libraries caused some regression in fetch speed.. This is all being fetched locally but it's consistently very slow

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hm.. probably shot in the dark, but iirc in IPLD explorer if local gateway is not available, we fallback to public one, so perhaps the slowness is because local gateway cant be used, and tests pass only on slow fallback?

test/e2e/setup/global-setup.js Outdated Show resolved Hide resolved
Copy link
Member Author

@SgtPooki SgtPooki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

self review. one minor change coming

@SgtPooki
Copy link
Member Author

@lidel i've got CI passing now and code is at a good point. Can you take a peek?

@SgtPooki
Copy link
Member Author

after this is merged, we will be at a good place to start removing ipfs, ipfs-core and others

Copy link
Member

@lidel lidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SgtPooki I seem to consistently have one test failing locally, is it passing for you? If its just me (I have a old slow PC on purpose) maybe we need to increase timeout? or I need to purge something?

1) settings.test.js:77:3 › Settings screen › Submit/Reset Public Subdomain Gateway ───────────────

    Test timeout of 30000ms exceeded.

    Error: elementHandle.click: Target closed
    =========================== logs ===========================
    attempting click action
      waiting for element to be visible, enabled and stable
        element is not enabled - waiting...
    ============================================================

      43 |   // Check if the submit button is not null, and click it only if it's available
      44 |   if (submitButton) {
    > 45 |     await submitButton.click()
         |                        ^
      46 |   }
      47 |   const hasExpectedClass = await checkClassWithTimeout(page, inputElement, expectedClass)
      48 |   expect(hasExpectedClass).toBe(true)

        at submitGatewayAndCheck (/home/lidel/project/ipfs-webui/test/e2e/settings.test.js:45:24)
        at /home/lidel/project/ipfs-webui/test/e2e/settings.test.js:87:5

    Pending operations:
      - elementHandle.click at test/e2e/settings.test.js:45:24


  1 failed
    settings.test.js:77:3 › Settings screen › Submit/Reset Public Subdomain Gateway ────────────────
  37 passed (55.4s)

src/bundles/identity.test.js Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@SgtPooki
Copy link
Member Author

@SgtPooki I seem to consistently have one test failing locally, is it passing for you? If its just me (I have a old slow PC on purpose) maybe we need to increase timeout?

Some tests were failing for me locally as well (remote rpc api usually).. but I got an intermittent failure for that settings page locally as well

@lidel
Copy link
Member

lidel commented Sep 12, 2024

Maybe we just were lucky on CI? I've re-run the same commit just to me sure.

@SgtPooki
Copy link
Member Author

i've got a fix for the remote RPC one that fixes them locally.

@SgtPooki
Copy link
Member Author

The job you kicked off succeeded, and you can see that e2e tests succeeded in the two commits after that, even though CI failed in total because of lint failures:

and then the latest had passing e2e tests as well: https://github.com/ipfs/ipfs-webui/actions/runs/10839174283?pr=2257

Copy link
Member

@lidel lidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I've figured it out. Sorry for blocking this @SgtPooki, it looked like race condition, but was the fault of my local /etc/hosts where I blackholed bafkreib6wedzfupqy7qh44sie42ub4mvfwnfukmw6s2564flajwnt4cvc4.ipfs.dweb.link while testing #2255.

The E2E test that was failing appends / to dweb.link, which made it run a subdomain-support test against the gateway, and it was failing on my box due to DNS failure (unable to confirm the URL is a valid subdomain gateway):

2024-09-13_02-30

Once I removed blackhole from /etc/hosts it started passing.

So no blocker, lgtm, thanks for being patient with me.

ps. Playwright tooling improved, the --ui mode is really nice, I did npm run test:e2e -- --ui --grep "Settings" to debug this.

@SgtPooki
Copy link
Member Author

SgtPooki commented Sep 13, 2024

No problem.

ps. Playwright tooling improved, the --ui mode is really nice, I did npm run test:e2e -- --ui --grep "Settings" to debug this.

absolutely. I've been running npm run test:e2e -- --headed --max-failures=1 --workers=1 --timeout=0 -g 'Blah' quite a bit during this PR..

@SgtPooki SgtPooki merged commit 99ba9ac into main Sep 13, 2024
22 checks passed
@SgtPooki SgtPooki deleted the 2250-webui-spawning-helia-and-failing-to-establish-libp2p-webtransport-connections branch September 13, 2024 19:41
ipfs-gui-bot pushed a commit that referenced this pull request Sep 23, 2024
## [4.3.1](v4.3.0...v4.3.1) (2024-09-23)

 CID `bafybeideglc722hiwhsy4kiyl2fivf5lr6wozy2iuixtgzkvl3v4hasaty`

 ---

### Bug Fixes

* **file-preview:** safeSubresourceGwUrl ([#2253](#2253)) ([bb861a3](bb861a3)), closes [/github.com//issues/2246#issuecomment-2322192398](https://github.com/ipfs//github.com/ipfs/ipfs-webui/issues/2246/issues/issuecomment-2322192398)
* **files:** avoid duplicated fetch during preview ([#2254](#2254)) ([eefae25](eefae25)), closes [#2217](#2217)
* **files:** prefer subdomain gw in copied share links ([#2255](#2255)) ([e8c4421](e8c4421))

### Trivial Changes

* .io → .tech ([b9f622d](b9f622d))
* browserslist@latest ([#2251](#2251)) ([809c55a](809c55a))
* Pull transifex translations ([#2258](#2258)) ([2250374](2250374))
* use ipld-explorer-components@7.0.2 ([#2257](#2257)) ([99ba9ac](99ba9ac))
@ipfs-gui-bot
Copy link
Collaborator

🎉 This PR is included in version 4.3.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

webui spawning helia and failing to establish libp2p webtransport connections
3 participants