Skip to content
This repository has been archived by the owner on Mar 23, 2023. It is now read-only.

chore: move create-s3-repo to examples folder #33

Merged
merged 5 commits into from
Apr 15, 2021

Conversation

achingbrain
Copy link
Member

The createRepo convenience function has a dependency on ipfs-repo which can create weird dependency loops.

Instead have it as an example of how to use this module then the user can copy it to their codebase and also becomes in charge of which version of ipfs-repo they use.

The `createRepo` convenience function has a dependency on `ipfs-repo`
which can create weird dependency loops.

Instead have it as an example of how to use this module then the user
can copy it to their codebase and also becomes in charge of which
version of `ipfs-repo` they use.
Copy link
Contributor

@jacobheun jacobheun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I removed the code snippet in the readme that was still referencing createRepo

@jacobheun jacobheun merged commit 9a6691c into master Apr 15, 2021
@jacobheun jacobheun deleted the fix/remove-create-s3-repo branch April 15, 2021 14:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants