chore: remove skips for ls tests

License: MIT Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
ipfs · Mar 18, 2019 · 9d4102e · 9d4102e
1 parent c021469
commit 9d4102e
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 31 deletions.
diff --git a/test/core/interface.spec.js b/test/core/interface.spec.js
@@ -62,16 +62,7 @@ describe('interface-ipfs-core tests', function () {
   })
 
   tests.filesRegular(defaultCommonFactory, {
-    skip: isNode ? [{
-      name: 'should ls with a base58 encoded CID',
-      reason: 'File sizes incompatible with go-ipfs https://github.com/ipfs/js-ipfs/issues/1934'
-    }, {
-      name: 'should readable stream ls with a base58 encoded CID',
-      reason: 'File sizes incompatible with go-ipfs https://github.com/ipfs/js-ipfs/issues/1934'
-    }, {
-      name: 'should pull stream ls with a base58 encoded CID',
-      reason: 'File sizes incompatible with go-ipfs https://github.com/ipfs/js-ipfs/issues/1934'
-    }] : [{
+    skip: isNode ? null : [{
       name: 'addFromStream',
       reason: 'Not designed to run in the browser'
     }, {
@@ -80,15 +71,6 @@ describe('interface-ipfs-core tests', function () {
     }, {
       name: 'addFromURL',
       reason: 'Not designed to run in the browser'
-    }, {
-      name: 'should ls with a base58 encoded CID',
-      reason: 'File sizes incompatible with go-ipfs https://github.com/ipfs/js-ipfs/issues/1934'
-    }, {
-      name: 'should readable stream ls with a base58 encoded CID',
-      reason: 'File sizes incompatible with go-ipfs https://github.com/ipfs/js-ipfs/issues/1934'
-    }, {
-      name: 'should pull stream ls with a base58 encoded CID',
-      reason: 'File sizes incompatible with go-ipfs https://github.com/ipfs/js-ipfs/issues/1934'
     }]
   })
 

diff --git a/test/http-api/interface.js b/test/http-api/interface.js
@@ -46,18 +46,7 @@ describe('interface-ipfs-core over ipfs-http-client tests', () => {
     ]
   })
 
-  tests.filesRegular(defaultCommonFactory, {
-    skip: [{
-      name: 'should ls with a base58 encoded CID',
-      reason: 'File sizes incompatible with go-ipfs https://github.com/ipfs/js-ipfs/issues/1934'
-    }, {
-      name: 'should readable stream ls with a base58 encoded CID',
-      reason: 'File sizes incompatible with go-ipfs https://github.com/ipfs/js-ipfs/issues/1934'
-    }, {
-      name: 'should pull stream ls with a base58 encoded CID',
-      reason: 'File sizes incompatible with go-ipfs https://github.com/ipfs/js-ipfs/issues/1934'
-    }]
-  })
+  tests.filesRegular(defaultCommonFactory)
 
   tests.filesMFS(defaultCommonFactory)