Skip to content
This repository has been archived by the owner on Feb 12, 2024. It is now read-only.

Tracking issue for ky removal #2801

Closed
hugomrdias opened this issue Mar 2, 2020 · 2 comments · Fixed by #2810
Closed

Tracking issue for ky removal #2801

hugomrdias opened this issue Mar 2, 2020 · 2 comments · Fixed by #2810
Assignees
@hugomrdias
Labels
exp/expert Having worked on the specific codebase is important pkg:http-client Issues related only to ipfs-http-client status/in-progress In progress

Comments

@hugomrdias
Copy link
Member

hugomrdias commented Mar 2, 2020 •
edited
Loading

ky has problems with node 13, clones responses https://github.com/ipfs/js-ipfs-http-client/blob/master/src/lib/error-handler.js#L12

Related:
https://github.com/ipfs/js-ipfs-http-client/issues/1117#issuecomment-589011968
ipfs-inactive/js-ipfs-http-client#1224 (comment) this needs to be patched in react-native not here
https://github.com/ipfs/js-ipfs-http-client/issues/1219#issuecomment-582846315
ipfs-inactive/js-ipfs-http-client#1224
@hugomrdias hugomrdias added status/in-progress In progress exp/expert Having worked on the specific codebase is important labels Mar 2, 2020
@hugomrdias hugomrdias self-assigned this Mar 2, 2020
@hugomrdias hugomrdias added the pkg:http-client Issues related only to ipfs-http-client label Mar 2, 2020
@achingbrain achingbrain mentioned this issue Mar 2, 2020
Closed
47 tasks
@hugomrdias hugomrdias mentioned this issue Mar 3, 2020
Merged
@pcowgill
Copy link
Contributor

pcowgill commented Mar 9, 2020

@hugomrdias Will this behavior from ky be preserved Treats non-2xx status codes as errors?

hugomrdias added a commit that referenced this issue Mar 11, 2020
@hugomrdias
feat: remove ky from http-client and utils (#2810)
9bc9625 
- we now use a simpler http lib 
- bundle size reduced
- some tests are now more stable
- search params handling is cleaner 

closes #2801
mistakia pushed a commit to mistakia/js-ipfs that referenced this issue Mar 22, 2020
@hugomrdias
feat: remove ky from http-client and utils (ipfs#2810)
dd42cf8 
- we now use a simpler http lib 
- bundle size reduced
- some tests are now more stable
- search params handling is cleaner 

closes ipfs#2801
@sholladay
Copy link

sholladay commented Apr 15, 2020 •
edited
Loading

Hey, Ky maintainer here. I wanted to see if there is something we could do to make Ky easier to use or better in some way? Looks like you had to re-implement some of Ky's behavior, which is unfortunate. Maybe we could provide an option related to cloning responses? If there are any other bugs that lead to this, I'd love to take a look and fix those since they were blockers for you and might be for other projects, too. Also, since you are using node-fetch now, I'm curious if you considered got?

SgtPooki referenced this issue in ipfs/js-kubo-rpc-client Aug 18, 2022
@hugomrdias
feat: remove ky from http-client and utils (#2810)
41ea529 
- we now use a simpler http lib 
- bundle size reduced
- some tests are now more stable
- search params handling is cleaner 

closes #2801
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@hugomrdias hugomrdias

Labels
exp/expert Having worked on the specific codebase is important pkg:http-client Issues related only to ipfs-http-client status/in-progress In progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: remove ky from http-client and utils ipfs/js-ipfs
3 participants
@hugomrdias @pcowgill @sholladay