Skip to content
This repository has been archived by the owner on Feb 12, 2024. It is now read-only.

Track: remove usage of node globals #2924

Closed
53 of 56 tasks
hugomrdias opened this issue Mar 13, 2020 · 0 comments
Closed
53 of 56 tasks

Track: remove usage of node globals #2924

hugomrdias opened this issue Mar 13, 2020 · 0 comments
Assignees
@hugomrdias

Comments

@hugomrdias
Copy link
Member

hugomrdias commented Mar 13, 2020 •
edited
Loading

Bundlers are starting to remove automatic polyfilling of node globals so we need to keep up.

datastore-idb up to 44% faster and 69% smaller

batch idb x 5.26 ops/sec ±4.57% (29 runs sampled)
batch level x 2.92 ops/sec ±3.76% (19 runs sampled)
Fastest is batch idb
    
size 37.32KB to 11.41KB
@hugomrdias hugomrdias self-assigned this Mar 13, 2020
hugomrdias added a commit to multiformats/js-multibase that referenced this issue Mar 13, 2020
@hugomrdias
fix: fix base32pad, cleanup
bd02451 
Fixes a bug in base32pad that did allow `7 ` in the alphabet.
Add buffer dependency related to this ipfs/js-ipfs#2924
Updates deps and fixes linter
Adds node 12 to CI and publishes only src and dist folders.
@hugomrdias hugomrdias mentioned this issue Mar 13, 2020
Merged
hugomrdias added a commit to multiformats/js-multiaddr that referenced this issue Mar 13, 2020
@hugomrdias
fix: use multibase and add buffer
dbc8607 
Adds buffer related to ipfs/js-ipfs#2924

Uses multibase to encode.
@hugomrdias hugomrdias mentioned this issue Mar 13, 2020
Merged
hugomrdias added a commit to multiformats/js-cid that referenced this issue Mar 13, 2020
@hugomrdias
fix: add buffer
738087e 
Adds buffer related to ipfs/js-ipfs#2924
@hugomrdias hugomrdias mentioned this issue Mar 13, 2020
Merged
hugomrdias added a commit to multiformats/js-multicodec that referenced this issue Mar 13, 2020
@hugomrdias
fix: add buffer
1a0ca7b 
Adds buffer related to ipfs/js-ipfs#2924
@hugomrdias hugomrdias mentioned this issue Mar 13, 2020
Merged
hugomrdias added a commit to ipfs/protons that referenced this issue Mar 14, 2020
@hugomrdias
fix: add buffer and allow browser tests
d214dad 
Add buffer dependency related to this ipfs/js-ipfs#2924

Remove dependency on path and fs and allow for browser tests.
This was referenced Mar 14, 2020
Merged
Merged
hugomrdias added a commit to multiformats/js-multihash that referenced this issue Mar 14, 2020
@hugomrdias
fix: add buffer
780b11b 
Adds buffer related to ipfs/js-ipfs#2924

Uses multibase to encode.
hugomrdias added a commit to libp2p/js-libp2p-crypto that referenced this issue Mar 15, 2020
@hugomrdias
fix: add buffer, cleanup, reduce size
c39c6ea 
- add buffer related to ipfs/js-ipfs#2924
- remove unnecessary eslint ignore
- remove tweelnacl and use node-forge
- remove browserify-aes  and use node-forge
- use multibase to encode b58
- require only sha256 from multihashing
- reduce bundle size

after all the deps here ipfs/js-ipfs#2924 are merged libp2p-crypto will be able to be bundle with `node: false` 🎉
@hugomrdias hugomrdias mentioned this issue Mar 15, 2020
Merged
hacdias pushed a commit to multiformats/js-multicodec that referenced this issue Mar 16, 2020
@hugomrdias @hacdias
fix: add buffer
156e29d 
Adds buffer related to ipfs/js-ipfs#2924
vmx pushed a commit to multiformats/js-cid that referenced this issue Mar 16, 2020
@hugomrdias @vmx
fix: add buffer
65681ef 
Adds buffer related to ipfs/js-ipfs#2924
jacobheun added a commit to multiformats/js-multiaddr that referenced this issue Mar 16, 2020
@hugomrdias @jacobheun
fix: use multibase, add buffer, remove ip dep (#113)
f245744 
* fix: use multibase and add buffer

Adds buffer related to ipfs/js-ipfs#2924

Uses multibase to encode.

* Update src/convert.js

Co-Authored-By: Jacob Heun <jacobheun@gmail.com>

* Update src/convert.js

Co-Authored-By: Jacob Heun <jacobheun@gmail.com>

* fix: remove ip dep

Co-authored-by: Jacob Heun <jacobheun@gmail.com>
jacobheun pushed a commit to multiformats/js-multihash that referenced this issue Mar 16, 2020
@hugomrdias @vmx
fix: add buffer dependency (#71)
1e91e64 
* fix: add buffer

Adds buffer related to ipfs/js-ipfs#2924

Uses multibase to encode.

* fix: cleanup

* fix: allow console calls in example

Co-authored-by: Volker Mische <volker.mische@gmail.com>
hugomrdias added a commit to hugomrdias/bl that referenced this issue Mar 16, 2020
@hugomrdias
fix: dont rely in node globals
24f829b 
This PR removes the dependency on node globals, so the users don't need to rely on browser bundlers magic.

related to ipfs/js-ipfs#2924
@hugomrdias hugomrdias mentioned this issue Mar 16, 2020
Closed
hugomrdias added a commit to hugomrdias/it-tar that referenced this issue Mar 16, 2020
@hugomrdias
fix: remove node globals
a21e3dc 
fs-contants relies on node constants global to exist and be injected by browser bundlers (which is super outdated).

iso-constants removes the need for the bundler to inject outdated packages and also auto updates the constants to the node version been used.

related to ipfs/js-ipfs#2924
This was referenced Mar 16, 2020
Closed
Merged
Merged
rvagg pushed a commit to rvagg/bl that referenced this issue Mar 18, 2020
@hugomrdias @rvagg
fix: dont rely in node globals
9b46588 
This PR removes the dependency on node globals, so the users don't need to rely on browser bundlers magic.

related to ipfs/js-ipfs#2924
alanshaw pushed a commit to alanshaw/it-tar that referenced this issue Mar 18, 2020
@hugomrdias
fix: remove node globals (#2)
dd06bff 
* fix: remove node globals

fs-contants relies on node constants global to exist and be injected by browser bundlers (which is super outdated).

iso-constants removes the need for the bundler to inject outdated packages and also auto updates the constants to the node version been used.

related to ipfs/js-ipfs#2924

* chore: fix lock
hugomrdias added a commit to hugomrdias/it-length-prefixed that referenced this issue Mar 18, 2020
@hugomrdias
fix: remove node globals
29caf11 
related to ipfs/js-ipfs#2924

`npx aegir test --node false` works 🎉
@hugomrdias hugomrdias mentioned this issue Mar 18, 2020
Merged
hugomrdias added a commit to libp2p/js-libp2p-mplex that referenced this issue Mar 18, 2020
@hugomrdias
fix: add buffer
60e0cbb 
related to ipfs/js-ipfs#2924
This was referenced Apr 20, 2020
Merged
Merged
hugomrdias added a commit to ipfs-shipyard/is-ipfs that referenced this issue Apr 22, 2020
@hugomrdias
fix: remove bs58 and add buffer
c5ad8b9 
ipfs/js-ipfs#2924
@hugomrdias hugomrdias mentioned this issue Apr 22, 2020
Merged
hugomrdias added a commit to libp2p/js-libp2p-pubsub that referenced this issue Apr 23, 2020
@hugomrdias
fix: remove node globals
24bb15a 
Related to ipfs/js-ipfs#2924
@hugomrdias hugomrdias mentioned this issue Apr 23, 2020
Merged
vasco-santos pushed a commit to libp2p/js-libp2p-pubsub that referenced this issue Apr 23, 2020
@hugomrdias
fix: remove node globals (#42)
636041b 
Related to ipfs/js-ipfs#2924
@hugomrdias hugomrdias mentioned this issue Apr 23, 2020
Merged
hugomrdias added a commit to ipfs/js-datastore-pubsub that referenced this issue Apr 23, 2020
@hugomrdias
fix: remove node globals
4a6f759 
Related to ipfs/js-ipfs#2924
@hugomrdias hugomrdias mentioned this issue Apr 23, 2020
Merged
hugomrdias added a commit to ipfs/js-ipfs-bitswap that referenced this issue Apr 23, 2020
@hugomrdias
fix: use ipld-block and remove node globals
a416d31 
- add buffer to the deps
- swaps ipfs-block with ipld-block
- removes safe-buffer
- updates deps

BREAKING CHANGE: swaps ipfs-block with ipld-block

related to ipfs/js-ipfs#2924
@hugomrdias hugomrdias mentioned this issue Apr 23, 2020
Merged
dirkmc pushed a commit to ipfs/js-ipfs-bitswap that referenced this issue Apr 23, 2020
@hugomrdias
fix: use ipld-block and remove node globals (#218)
6b4dc32 
- add buffer to the deps
- swaps ipfs-block with ipld-block
- removes safe-buffer
- updates deps

BREAKING CHANGE: swaps ipfs-block with ipld-block

related to ipfs/js-ipfs#2924
hugomrdias added a commit to libp2p/js-libp2p-record that referenced this issue Apr 23, 2020
@hugomrdias
fix: remove buffer
bd6a99f 
related to ipfs/js-ipfs#2924
@hugomrdias hugomrdias mentioned this issue Apr 23, 2020
Merged
vasco-santos pushed a commit to ipfs/js-datastore-pubsub that referenced this issue Apr 24, 2020
@hugomrdias
fix: remove node globals (#21)
be8de2c 
* fix: remove node globals

Related to ipfs/js-ipfs#2924
vasco-santos pushed a commit to libp2p/js-libp2p-record that referenced this issue Apr 27, 2020
@hugomrdias
fix: remove buffer (#21)
80fb248 
related to ipfs/js-ipfs#2924
@hugomrdias hugomrdias mentioned this issue Apr 28, 2020
Merged
@hugomrdias hugomrdias mentioned this issue May 12, 2020
Merged
@achingbrain achingbrain mentioned this issue Jun 5, 2020
Closed
@hugomrdias hugomrdias mentioned this issue Jun 11, 2020
Merged
@hugomrdias hugomrdias mentioned this issue Jun 19, 2020
Merged
1 task
This was referenced Jul 1, 2020
Merged
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@hugomrdias hugomrdias

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hugomrdias