-
Notifications
You must be signed in to change notification settings - Fork 1.2k
ipfs-core-types is incorrectly built on npm #3976
Comments
Thank you for submitting your first issue to this repository! A maintainer will be here shortly to triage and review.
Finally, remember to use https://discuss.ipfs.io if you just need general support. |
I've added temporary workaround in my project but I'm looking forward to find that problem fixed as it holds me back a little bit ;) |
This sounds like the |
Actually I'm able to reproduce this outside of my project. I'm doing this like this:
As you can see, for example file Interestingly I tried building the package locally from checkout using:
In this case the resulting package had all the files in src. So I'm not really sure what went wrong, it seems that building scripts are fine, just this particular build in npm is broken. |
I'm encountering the same problem! I hope the team has some time to fix this soon! |
So I made an experiment with a fork (flynnhou@796ba40) for my project too. I'm not an expert on TypeScript and the TL;DRRemoving the problematic built Ad Hoc WorkaroundSince I didn't spend too much time getting familiar with js-ipfs project development, I didn't fully get how to install my fork repo as an alternative in the entire build flow. My ugly ad hoc workaround is that in {
"scripts": {
"postinstall": "rm -rf node_modules/ipfs-core-types/src"
},
"dependencies": {
"ipfs-core": "^0.13.0",
}
} |
@achingbrain any thoughts on that? |
Maintainers will check in on this during 2022-03-04 triage. |
When using `copyfiles` globstars need to be quoted on a Mac otherwise they don't work See the README at https://www.npmjs.com/package/copyfiles Fixes #3976
When using `copyfiles` globstars need to be quoted on a Mac otherwise they don't work See the README at https://www.npmjs.com/package/copyfiles Fixes #3976
@achingbrain I confirm it worked |
2022-03-25 conversation: we're going to close this issue once the build is passing. |
This should be resolved in the latest patch release, no need to use |
Hi, I'm getting a wall of these
I've tried removing node modules and starting afresh, also with Is this definitely fixed or are there still steps needed to manage these typescript warnings? Thanks for any help! |
I am getting a similar issue to @tomjohnhall, "ipfs-core": "^0.15.4", |
2022-07-22 update: we will release a new version of js-libp2p the week of 2022-07-25 and will bubble it up to js-ipfs and do a release. We expect the next js-ipfs release to address this. |
Oops, seems like we needed more information for this issue, please comment with more details or this issue will be closed in 7 days. |
This issue was closed because it is missing author input. |
ipfs-core-types@0.8.4
Severity:
High
Description:
When installed with npm, package is missing "dist" folder.
It works well if built and linked locally
Steps to reproduce the error:
Use ipfs-core-types package installed with npm
The text was updated successfully, but these errors were encountered: